linux-kernel - Re: [PATCH v3 13/68] selftests/damon: Drop define _GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu,  9 May 2024 13:31:13 -0700
From: SeongJae Park <sj@...nel.org>
To: Edward Liaw <edliaw@...gle.com>
Cc: SeongJae Park <sj@...nel.org>,
	shuah@...nel.org,
	"Mickaël Salaün" <mic@...ikod.net>,
	"Günther Noack" <gnoack@...gle.com>,
	Christian Brauner <brauner@...nel.org>,
	Richard Cochran <richardcochran@...il.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	John Fastabend <john.fastabend@...il.com>,
	Muhammad Usama Anjum <usama.anjum@...labora.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	kernel-team@...roid.com,
	linux-security-module@...r.kernel.org,
	netdev@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	bpf@...r.kernel.org,
	damon@...ts.linux.dev,
	linux-mm@...ck.org,
	mathieu.desnoyers@...icios.com
Subject: Re: [PATCH v3 13/68] selftests/damon: Drop define _GNU_SOURCE

Hi Edward,

On Thu,  9 May 2024 19:58:05 +0000 Edward Liaw <edliaw@...gle.com> wrote:

> _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> redefinition warnings.
> 
> Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")

I show Mathieu's comment on this[1].  I have no strong opinion on this, but if
you conclude to remove or change this line, please apply same change to this
patch.

[1] https://lore.kernel.org/638a7831-493c-4917-9b22-5aa663e9ee84@efficios.com

> Signed-off-by: Edward Liaw <edliaw@...gle.com>

I also added trivial comments that coming from my personal and humble
preferrence below.  Other than the above and the below comments,

Reviewed-by: SeongJae Park <sj@...nel.org>

> ---
>  tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c    | 3 ---
>  .../damon/debugfs_target_ids_read_before_terminate_race.c      | 2 --
>  2 files changed, 5 deletions(-)
> 
> diff --git a/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c b/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c
> index 0cc2eef7d142..7a17a03d555c 100644
> --- a/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c
> +++ b/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c
> @@ -2,9 +2,6 @@
>  /*
>   * Author: SeongJae Park <sj@...nel.org>
>   */
> -
> -#define _GNU_SOURCE
> -
>  #include <fcntl.h>

I'd prefer having one empty line between the comment and includes.

>  #include <stdbool.h>
>  #include <stdint.h>
> diff --git a/tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.c b/tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.c
> index b06f52a8ce2d..4aeac55ac93e 100644
> --- a/tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.c
> +++ b/tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.c
> @@ -2,8 +2,6 @@
>  /*
>   * Author: SeongJae Park <sj@...nel.org>
>   */
> -#define _GNU_SOURCE
> -
>  #include <fcntl.h>

Ditto.

And I realize I also forgot adding one empty line before the above #define
line.  That's why I'm saying this is just a trivial comment :)

>  #include <stdbool.h>
>  #include <stdint.h>
> -- 
> 2.45.0.118.g7fe29c98d7-goog


Thanks,
SJ