linux-kernel - Re: [PATCH] clk: qcom: Constify struct pll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27cd559d7cc47fe38437570e57ec7a99.sboyd@kernel.org>
Date: Fri, 10 May 2024 13:14:37 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Bjorn Andersson <andersson@...nel.org>, Christophe JAILLET <christophe.jaillet@...adoo.fr>, Michael Turquette <mturquette@...libre.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, Christophe JAILLET <christophe.jaillet@...adoo.fr>, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: Constify struct pll_vco

Quoting Christophe JAILLET (2024-05-10 09:50:00)
> pll_vco structure are never modified. They are used as .vco_table in
> "struct clk_alpha_pll".
> 
> And in this structure, we have:
>         const struct pll_vco *vco_table;
> 
> Constifying these structures moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig:
> Before:
>    text    data     bss     dec     hex filename
>    9905   47576       0   57481    e089 drivers/clk/qcom/mmcc-msm8994.o
> 
> After:
>    text    data     bss     dec     hex filename
>   10033   47440       0   57473    e081 drivers/clk/qcom/mmcc-msm8994.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

Acked-by: Stephen Boyd <sboyd@...nel.org>