[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240509202808.26e960a7@kernel.org>
Date: Thu, 9 May 2024 20:28:08 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Geetha sowjanya <gakula@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
<sgoutham@...vell.com>, <sbhatta@...vell.com>, <hkelam@...vell.com>
Subject: Re: [net-next PATCH v4 03/10] octeontx2-pf: Create representor
netdev
On Tue, 7 May 2024 22:09:14 +0530 Geetha sowjanya wrote:
> + priv->reps = devm_kcalloc(priv->dev, rep_cnt, sizeof(struct rep_dev *),
> + GFP_KERNEL);
> + if (!priv->reps)
> + return -ENOMEM;
using devm_ here is pointless, the objects are not tied to the lifetime
of the device (there can be created multiple times) and you have to
unregister the netdevs manually, anyway.
Powered by blists - more mailing lists