linux-kernel - Re: [PATCH net-next v2 1/3] net: dsa: microchip: dcb: rename IPV to IPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240509204306.1b4e77e5@kernel.org>
Date: Thu, 9 May 2024 20:43:06 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
 Eric Dumazet <edumazet@...gle.com>, Florian Fainelli
 <f.fainelli@...il.com>, Paolo Abeni <pabeni@...hat.com>, Vladimir Oltean
 <olteanv@...il.com>, Woojung Huh <woojung.huh@...rochip.com>, Arun Ramadoss
 <arun.ramadoss@...rochip.com>, kernel@...gutronix.de,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 UNGLinuxDriver@...rochip.com, David Ahern <dsahern@...nel.org>, Simon
 Horman <horms@...nel.org>, Willem de Bruijn <willemb@...gle.com>,
 Søren Andersen <san@...v.dk>
Subject: Re: [PATCH net-next v2 1/3] net: dsa: microchip: dcb: rename IPV to
 IPM

On Thu,  9 May 2024 07:33:33 +0200 Oleksij Rempel wrote:
> IPV is added and used term in 802.1Qci PSFP and merged into 802.1Q (from
> 802.1Q-2018) for another functions.
> 
> Even it does similar operation holding temporal priority value
> internally (as it is named), because KSZ datasheet doesn't use the term
> of IPV (Internal Priority Value) and avoiding any confusion later when
> PSFP is in the Linux world, it is better to rename IPV to IPM (Internal
> Priority Mapping).
> 
> In addition, LAN937x documentation already use IPV for 802.1Qci PSFP
> related functionality.

Transient build failure here:

drivers/net/dsa/microchip/ksz_dcb.c: In function ‘ksz_set_global_dscp_entry’:
drivers/net/dsa/microchip/ksz_dcb.c:323:25: error: ‘ipm’ undeclared (first use in this function); did you mean ‘ipv’?
  323 |                         ipm << shift);
      |                         ^~~
      |                         ipv
-- 
pw-bot: cr