[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b2ed9fed-0263-405d-9e5a-71c49421619a@t-8ch.de>
Date: Fri, 10 May 2024 08:58:05 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Edward Liaw <edliaw@...gle.com>
Cc: shuah@...nel.org,
Mickaël Salaün <mic@...ikod.net>, Günther Noack <gnoack@...gle.com>,
Christian Brauner <brauner@...nel.org>, Richard Cochran <richardcochran@...il.com>,
Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>, Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>, "David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>,
John Fastabend <john.fastabend@...il.com>, Willy Tarreau <w@....eu>, linux-kernel@...r.kernel.org,
linux-kselftest@...r.kernel.org, kernel-team@...roid.com, linux-security-module@...r.kernel.org,
netdev@...r.kernel.org, linux-riscv@...ts.infradead.org, bpf@...r.kernel.org
Subject: Re: [PATCH v4 37/66] selftests/nolibc: Drop define _GNU_SOURCE
Hi Edward,
On 2024-05-10 00:06:54+0000, Edward Liaw wrote:
> _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> redefinition warnings.
The nolibc tests do not use lib.mk.
This change breaks "make libc-test", please drop it.
> Signed-off-by: Edward Liaw <edliaw@...gle.com>
> ---
> tools/testing/selftests/nolibc/nolibc-test.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> index 94bb6e11c16f..a28813f4367f 100644
> --- a/tools/testing/selftests/nolibc/nolibc-test.c
> +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> @@ -1,6 +1,4 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> -
> -#define _GNU_SOURCE
> #define _LARGEFILE64_SOURCE
>
> /* libc-specific include files
> --
> 2.45.0.118.g7fe29c98d7-goog
Thomas
Powered by blists - more mailing lists