linux-kernel - Re: [PATCH v3] crypto: ecc - Prevent ecc_digits_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D15T7OSYSX5S.3G35QSFEIHU8F@kernel.org>
Date: Fri, 10 May 2024 11:08:42 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Stefan Berger" <stefanb@...ux.ibm.com>, <keyrings@...r.kernel.org>,
 <linux-crypto@...r.kernel.org>, <herbert@...dor.apana.org.au>,
 <davem@...emloft.net>
Cc: <linux-kernel@...r.kernel.org>, <lukas@...ner.de>
Subject: Re: [PATCH v3] crypto: ecc - Prevent ecc_digits_from_bytes from
 reading too many bytes

On Fri May 10, 2024 at 4:59 AM EEST, Stefan Berger wrote:
> +		memcpy((u8 *)&msd + sizeof(msd) - o, in, o);

Not a review/NAK comment but I personally prefer to treat these
like arrays:

&((u8 *)&msd)[sizeof(msd) - o]

It is totally fine as it is.

BR, Jarkko