lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 10 May 2024 12:04:31 +0100
From: Vincent Donnefort <vdonnefort@...gle.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Shuah Khan <skhan@...uxfoundation.org>, mhiramat@...nel.org,
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
	mathieu.desnoyers@...icios.com, kernel-team@...roid.com,
	rdunlap@...radead.org, rppt@...nel.org, david@...hat.com,
	Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
	Muhammad Usama Anjum <usama.anjum@...labora.com>
Subject: Re: [PATCH v22 5/5] ring-buffer/selftest: Add ring-buffer mapping
 test

On Tue, May 07, 2024 at 07:35:55PM -0400, Steven Rostedt wrote:
> On Fri, 3 May 2024 13:12:56 -0600
> Shuah Khan <skhan@...uxfoundation.org> wrote:
> 
> > On 4/30/24 05:13, Vincent Donnefort wrote:
> > > This test maps a ring-buffer and validate the meta-page after reset and
> > > after emitting few events.
> > >   
> > 
> > Changelog needs to be imperative - refer to the following:
> > 
> > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> > 
> > Update the change log and describe what the test does and include
> > test output.
> > 
> > If the test requires root privileges - make sure add a check to skip
> > when a normal use runs the test.
> > 
> > The rest looks good.
> > 
> 
> Vincent,
> 
> Can you address Shuah's concerns. I'm starting to test patches 1-4 so
> you only need to send an update to this one, unless of course I find an
> issue with one of the others.

I will do, as well as with the VM_ flags change.

Thanks for having a look Shuah.

> 
> Thanks,
> 
> -- Steve

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ