linux-kernel - Re: [PATCH net-next v2 00/14] net: qede: convert filter code to use extack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240510112511.GC2347895@kernel.org>
Date: Fri, 10 May 2024 12:25:11 +0100
From: Simon Horman <horms@...nel.org>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Manish Chopra <manishc@...vell.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH net-next v2 00/14] net: qede: convert filter code to use
 extack

On Wed, May 08, 2024 at 02:33:48PM +0000, Asbjørn Sloth Tønnesen wrote:
> This series converts the filter code in the qede driver
> to use NL_SET_ERR_MSG_*(extack, ...) for error handling.
> 
> Patch 1-12 converts qede_parse_flow_attr() to use extack,
> along with all it's static helper functions.
> 
> qede_parse_flow_attr() is used in two places:
> - qede_add_tc_flower_fltr()
> - qede_flow_spec_to_rule()
> 
> In the latter call site extack is faked in the same way as
> is done in mlxsw (patch 12).
> 
> While the conversion is going on, some error messages are silenced
> in between patch 1-12. If wanted could squash patch 1-12 in a v3, but
> I felt that it would be easier to review as 12 more trivial patches.

FWIIW, I like the easy to review approach taken here :)

> Patch 13 and 14, finishes up by converting qede_parse_actions(),
> and ensures that extack is propagated to it, in both call contexts.

..