linux-kernel - Re: [PATCH v2 1/2] Revert "selftests/harness: remove use of LINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 10 May 2024 13:33:12 +0100
From: Simon Horman <horms@...nel.org>
To: Tao Su <tao1.su@...ux.intel.com>
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org, kvm@...r.kernel.org,
	netdev@...r.kernel.org, linux-rtc@...r.kernel.org,
	linux-sgx@...r.kernel.org, akpm@...ux-foundation.org,
	edliaw@...gle.com, ivan.orlov0322@...il.com, broonie@...nel.org,
	perex@...ex.cz, tiwai@...e.com, shuah@...nel.org, seanjc@...gle.com,
	pbonzini@...hat.com, bongsu.jeon@...sung.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	alexandre.belloni@...tlin.com, jarkko@...nel.org,
	dave.hansen@...ux.intel.com
Subject: Re: [PATCH v2 1/2] Revert "selftests/harness: remove use of LINE_MAX"

On Thu, May 09, 2024 at 01:31:12PM +0800, Tao Su wrote:
> This reverts commit 8092162335554c8ef5e7f50eff68aa9cfbdbf865.
> 
> asprintf() is declared in stdio.h when defining _GNU_SOURCE, but stdio.h
> is so common that many files don’t define _GNU_SOURCE before including
> stdio.h, and defining _GNU_SOURCE after including stdio.h will no longer
> take effect, which causes warnings or even errors during compilation in
> many selftests.
> 
> Revert 'commit 809216233555 ("selftests/harness: remove use of LINE_MAX")'
> as that came in quite late in the 6.9 cycle.
> 
> Link: https://lore.kernel.org/linux-kselftest/ZjuA3aY_iHkjP7bQ@google.com/
> Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
> Signed-off-by: Tao Su <tao1.su@...ux.intel.com>

Reviewed-by: Simon Horman <horms@...nel.org>