[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <663e2aa4.050a0220.a4c56.1c5a@mx.google.com>
Date: Fri, 10 May 2024 16:09:37 +0200
From: Christian Marangi <ansuelsmth@...il.com>
To: Kalle Valo <kvalo@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
linux-kernel@...r.kernel.org, ath10k@...ts.infradead.org,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
Sebastian Gottschall <s.gottschall@...wrt.com>,
Steve deRosier <derosier@...-sierra.com>,
Stefan Lippers-Hollmann <s.l-h@....de>
Subject: Re: [PATCH v14] ath10k: add LED and GPIO controlling support for
various chipsets
On Fri, May 10, 2024 at 04:50:52PM +0300, Kalle Valo wrote:
> Christian Marangi <ansuelsmth@...il.com> writes:
>
> >>
> >> Sorry for the delay but finally I looked at this again. I decided to
> >> just remove the fixme and otherwise it looks good for me. Please check
> >> my changes:
> >>
> >> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=688130a66ed49f20ca0ce02c3987f6a474f7c93a
> >>
> >
> > All ok for me, Just I notice the ATH10K_LEDS is not exposed anymore? Is
> > that intended?
>
> Yes. It follows the same idea as other wireless drivers do, for example iwlwifi:
>
> config IWLWIFI_LEDS
> bool
> depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> depends on IWLMVM || IWLDVM
> select LEDS_TRIGGERS
> select MAC80211_LEDS
> default y
>
> So what this patch now does:
>
> config ATH10K_LEDS
> bool
> depends on ATH10K
> depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> default y
>
> The idea being that if LEDS_CLASS is enabled then ATH10K_LEDS is
> automatically enabled. But please let us know if something is wrong
> here.
>
Sure, was just asking some clarification about it. Not a problem for me
since we are using other pattern to handle this.
--
Ansuel
Powered by blists - more mailing lists