linux-kernel - Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zj447ePSnccbj76v@smile.fi.intel.com>
Date: Fri, 10 May 2024 18:10:37 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Devarsh Thakkar <devarsht@...com>
Cc: mchehab@...nel.org, hverkuil-cisco@...all.nl,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	benjamin.gaignard@...labora.com, sebastian.fricke@...labora.com,
	dri-devel@...ts.freedesktop.org, laurent.pinchart@...asonboard.com,
	praneeth@...com, nm@...com, vigneshr@...com, a-bhatia1@...com,
	j-luthra@...com, b-brnich@...com, detheridge@...com,
	p-mantena@...com, vijayp@...com, andrzej.p@...labora.com,
	nicolas@...fresne.ca, p.zabel@...gutronix.de, airlied@...il.com,
	daniel@...ll.ch, akpm@...ux-foundation.org,
	gregkh@...uxfoundation.org, adobriyan@...il.com,
	jani.nikula@...el.com
Subject: Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for
 cropping region

On Fri, May 10, 2024 at 12:10:01AM +0530, Devarsh Thakkar wrote:
> If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up
> (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest
> multiple of requested value while updating the crop rectangle coordinates.
> 
> Use the rounding macro which gives preference to rounding down in case two
> nearest values (high and low) are possible to raise the probability of
> cropping rectangle falling inside the bound region.

This is arguable. How do we know that the bigger range is supported?
The safest side is to go smaller than bigger.

-- 
With Best Regards,
Andy Shevchenko