linux-kernel - Re: [PATCH 1/2] genirq/affinity: remove rsvd check against minvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zj46KiMO5trL09RA@fedora>
Date: Fri, 10 May 2024 23:15:54 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Keith Busch <kbusch@...a.com>
Cc: linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
	hch@....de, tglx@...utronix.de, Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCH 1/2] genirq/affinity: remove rsvd check against minvec

On Fri, May 10, 2024 at 07:14:58AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@...nel.org>
> 
> The reserved vectors are just the desired vectors that don't need to be
> managed.
> 
> Signed-off-by: Keith Busch <kbusch@...nel.org>
> ---
>  kernel/irq/affinity.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
> index 44a4eba80315c..74b7cccb51a16 100644
> --- a/kernel/irq/affinity.c
> +++ b/kernel/irq/affinity.c
> @@ -113,9 +113,6 @@ unsigned int irq_calc_affinity_vectors(unsigned int minvec, unsigned int maxvec,
>  	unsigned int resv = affd->pre_vectors + affd->post_vectors;
>  	unsigned int set_vecs;
>  
> -	if (resv > minvec)
> -		return 0;
> -

This behavior is introduced in 6f9a22bc5775 ("PCI/MSI: Ignore affinity if pre/post
vector count is more than min_vecs"), which is one bug fix.

Thanks,
Ming