[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zj46vpwTbfde4YX2@smile.fi.intel.com>
Date: Fri, 10 May 2024 18:18:22 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Bingbu Cao <bingbu.cao@...el.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Hans de Goede <hdegoede@...hat.com>,
Daniel Scally <dan.scally@...asonboard.com>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] media: ipu-bridge: fix error code in ipu_bridge_init()
On Fri, May 10, 2024 at 06:10:37PM +0300, Dan Carpenter wrote:
> Return -EINVAL if "bridge->n_sensors == 0". Don't return success.
..
> ret = ipu_bridge_connect_sensors(bridge);
> - if (ret || bridge->n_sensors == 0)
> + if (ret || bridge->n_sensors == 0) {
> + ret = ret ?: -EINVAL;
> goto err_unregister_ipu;
> + }
I would split:
ret = ipu_bridge_connect_sensors(bridge);
if (ret)
goto err_unregister_ipu;
if (bridge->n_sensors == 0) {
ret = -EINVAL;
goto err_unregister_ipu;
}
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists