[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <57a0dfae-cf1b-4c98-bc54-e70e722adf99@moroto.mountain>
Date: Fri, 10 May 2024 18:42:46 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Bingbu Cao <bingbu.cao@...el.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Hans de Goede <hdegoede@...hat.com>,
Daniel Scally <dan.scally@...asonboard.com>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] media: ipu-bridge: fix error code in ipu_bridge_init()
On Fri, May 10, 2024 at 06:36:36PM +0300, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 06:27:30PM +0300, Dan Carpenter wrote:
> > On Fri, May 10, 2024 at 06:18:22PM +0300, Andy Shevchenko wrote:
> > > On Fri, May 10, 2024 at 06:10:37PM +0300, Dan Carpenter wrote:
> > > > Return -EINVAL if "bridge->n_sensors == 0". Don't return success.
>
> ...
>
> > > > ret = ipu_bridge_connect_sensors(bridge);
> > > > - if (ret || bridge->n_sensors == 0)
> > > > + if (ret || bridge->n_sensors == 0) {
> > > > + ret = ret ?: -EINVAL;
> > > > goto err_unregister_ipu;
> > > > + }
> > >
> > > I would split:
> > >
> > > ret = ipu_bridge_connect_sensors(bridge);
> > > if (ret)
> > > goto err_unregister_ipu;
> > >
> > > if (bridge->n_sensors == 0) {
> > > ret = -EINVAL;
> > > goto err_unregister_ipu;
> > > }
> >
> > It's always hard to know which way to go on these... I wrote it that
> > way in my first draft. It's my prefered way as well but not everyone
> > agrees. I'll resend.
>
> Is the generated assembly the same?
Yeah, it does.
regards,
dan carpenter
Powered by blists - more mailing lists