linux-kernel - Re: [PATCH] apparmor: fix apparmor_socket_post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00107f4f-9a14-43b0-8204-45978a487e33@canonical.com>
Date: Fri, 10 May 2024 08:58:10 -0700
From: John Johansen <john.johansen@...onical.com>
To: Jeff Johnson <quic_jjohnson@...cinc.com>, Paul Moore
 <paul@...l-moore.com>, James Morris <jmorris@...ei.org>,
 "Serge E. Hallyn" <serge@...lyn.com>
Cc: apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apparmor: fix apparmor_socket_post_create() kernel-doc

On 5/5/24 15:39, Jeff Johnson wrote:
> make C=1 reports:
> 
> security/apparmor/lsm.c:1138: warning: Function parameter or struct member 'protocol' not described in 'apparmor_socket_post_create'
> 
> Fix this by correcting the misspelling of 'protocol'.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>

Hey Jeff, thanks for the patch, unfortunately Christian Göttsche version of the patch came in before yours so that is the one I committed

> ---
>   security/apparmor/lsm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index cef8c466af80..d0485fb0ed63 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -1124,7 +1124,7 @@ static int apparmor_socket_create(int family, int type, int protocol, int kern)
>    * @sock: socket that is being setup
>    * @family: family of socket being created
>    * @type: type of the socket
> - * @ptotocol: protocol of the socket
> + * @protocol: protocol of the socket
>    * @kern: socket is a special kernel socket
>    *
>    * Note:
> 
> ---
> base-commit: 2c4d8e19cf060744a9db466ffbaea13ab37f25ca
> change-id: 20240505-apparmor_socket_post_create-kdoc-897c7ad5d007
>