linux-kernel - Re: [PATCH v4 2/3] dt-bindings: phy: Add i.MX8Q HSIO SerDes PHY binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zj5G4B/aHq4WlunT@lizhi-Precision-Tower-5810>
Date: Fri, 10 May 2024 12:10:08 -0400
From: Frank Li <Frank.li@....com>
To: Conor Dooley <conor@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Richard Zhu <hongxing.zhu@....com>,
	vkoul@...nel.org, kishon@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de, imx@...ts.linux.dev
Subject: Re: [PATCH v4 2/3] dt-bindings: phy: Add i.MX8Q HSIO SerDes PHY
 binding

On Fri, May 10, 2024 at 04:52:22PM +0100, Conor Dooley wrote:
> On Fri, May 10, 2024 at 10:38:49AM -0500, Rob Herring wrote:
> > On Thu, May 09, 2024 at 01:56:20PM +0800, Richard Zhu wrote:
> > > +  fsl,refclk-pad-mode:
> > > +    description:
> > > +      Specifies the mode of the refclk pad used. INPUT(PHY refclock is
> > > +      provided externally via the refclk pad) or OUTPUT(PHY refclock is
> > > +      derived from SoC internal source and provided on the refclk pad).
> > > +    $ref: /schemas/types.yaml#/definitions/string
> > > +    enum: [ "input", "output" ]
> > 
> > default?
> > 
> > Really, this could just be a boolean for the non-default mode.
> 
> There's actually a third option, or at least there was in v1, unused.
> The description in v1 was:
> 
>       It can be UNUSED(PHY
>       refclock is derived from SoC internal source), INPUT(PHY refclock
>       is provided externally via the refclk pad) or OUTPUT(PHY refclock
>       is derived from SoC internal source and provided on the refclk pad).
> 
> I suggested that there should be 3 strings and not having the property
> would mean unused. But all mention of unused seems to have vanished :/

Yes, missed mention about unused.

Is it okay about "fsl,refclk-pad-mode not exist means unused ?

Of course, need mention in description. 


Frank