linux-kernel - Re: [PATCH] time: add MODULE_DESCRIPTION() to time test modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <779507fe-8794-47f8-9c9c-9dbd5cbe899f@paulmck-laptop>
Date: Fri, 10 May 2024 21:31:57 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: John Stultz <jstultz@...gle.com>, Thomas Gleixner <tglx@...utronix.de>,
	Stephen Boyd <sboyd@...nel.org>,
	David Riley <davidriley@...omium.org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] time: add MODULE_DESCRIPTION() to time test modules

On Fri, May 10, 2024 at 05:24:25PM -0700, Jeff Johnson wrote:
> Fix the make W=1 warnings:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/clocksource-wdtest.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/test_udelay.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/time_test.o
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>

>From a clocksource-watchdog-test perspective:

Acked-by: Paul E. McKenney <paulmck@...nel.org>

> ---
>  kernel/time/clocksource-wdtest.c | 1 +
>  kernel/time/test_udelay.c        | 1 +
>  kernel/time/time_test.c          | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/kernel/time/clocksource-wdtest.c b/kernel/time/clocksource-wdtest.c
> index d06185e054ea..62e73444ffe4 100644
> --- a/kernel/time/clocksource-wdtest.c
> +++ b/kernel/time/clocksource-wdtest.c
> @@ -22,6 +22,7 @@
>  #include "tick-internal.h"
>  
>  MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Clocksource watchdog unit test");
>  MODULE_AUTHOR("Paul E. McKenney <paulmck@...nel.org>");
>  
>  static int holdoff = IS_BUILTIN(CONFIG_TEST_CLOCKSOURCE_WATCHDOG) ? 10 : 0;
> diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c
> index 20d5df631570..783f2297111b 100644
> --- a/kernel/time/test_udelay.c
> +++ b/kernel/time/test_udelay.c
> @@ -155,5 +155,6 @@ static void __exit udelay_test_exit(void)
>  
>  module_exit(udelay_test_exit);
>  
> +MODULE_DESCRIPTION("udelay test module");
>  MODULE_AUTHOR("David Riley <davidriley@...omium.org>");
>  MODULE_LICENSE("GPL");
> diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
> index 3e5d422dd15c..2889763165e5 100644
> --- a/kernel/time/time_test.c
> +++ b/kernel/time/time_test.c
> @@ -96,4 +96,5 @@ static struct kunit_suite time_test_suite = {
>  };
>  
>  kunit_test_suite(time_test_suite);
> +MODULE_DESCRIPTION("time unit test suite");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: dd5a440a31fae6e459c0d6271dddd62825505361
> change-id: 20240510-time-md-0f1514019230
>