linux-kernel - Re: [RFC PATCH] ASoC: dt-bindings: alc5623: convert to dt schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 11 May 2024 00:24:32 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Aryabhatta Dey <aryabhattadey35@...il.com>
Cc: skhan@...uxfoundation.org, linux-sound@...r.kernel.org, 
 lgirdwood@...il.com, linux-kernel@...r.kernel.org, conor+dt@...nel.org, 
 devicetree@...r.kernel.org, javier.carrasco.cruz@...il.com, 
 krzk+dt@...nel.org, broonie@...nel.org
Subject: Re: [RFC PATCH] ASoC: dt-bindings: alc5623: convert to dt schema


On Sat, 11 May 2024 10:11:24 +0530, Aryabhatta Dey wrote:
> Convert Documentation/bindings/devicetree/alc5623.txt to yaml.
> 
> First attempt at a dt schema conversion patch.
> Checked the yaml file with make dt_binding_check and make CHECK_DTBS=y.
> Only warning being produced is
> Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition
> Not sure how I should handle this.
> 
> Signed-off-by: Aryabhatta Dey <aryabhattadey35@...il.com>
> ---
>  .../devicetree/bindings/sound/alc5623.txt     | 25 ----------
>  .../bindings/sound/realtek,alc5623.yaml       | 48 +++++++++++++++++++
>  2 files changed, 48 insertions(+), 25 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/alc5623.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/realtek,alc5623.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/realtek,alc5623.example.dtb: codec@1a: '#gpio-cells' is a required property
	from schema $id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/realtek,alc5623.example.dtb: codec@1a: 'gpio-controller' is a required property
	from schema $id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/realtek,alc5623.example.dtb: codec@1a: 'add-ctrl', 'jack-det-ctrl' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/j2f5m3lydlkipt3vnyikeoq5bx6tsf6z22ljpspcgtnohy65on@htyjjd3ojkde

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.