linux-kernel - Re: [RFC 4/4] perf sched schedstat: Add support for report subcommand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zj8iMV9vhyGC3tT9@chenyu5-mobl2>
Date: Sat, 11 May 2024 15:45:53 +0800
From: Chen Yu <yu.c.chen@...el.com>
To: Ravi Bangoria <ravi.bangoria@....com>
CC: <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
	<namhyung@...nel.org>, <irogers@...gle.com>, <swapnil.sapkal@....com>,
	<mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
	<jolsa@...nel.org>, <rostedt@...dmis.org>, <vincent.guittot@...aro.org>,
	<bristot@...hat.com>, <adrian.hunter@...el.com>, <james.clark@....com>,
	<kan.liang@...ux.intel.com>, <gautham.shenoy@....com>,
	<kprateek.nayak@....com>, <juri.lelli@...hat.com>,
	<yangjihong@...edance.com>, <linux-kernel@...r.kernel.org>,
	<linux-perf-users@...r.kernel.org>, <santosh.shukla@....com>,
	<ananth.narayan@....com>, <sandipan.das@....com>
Subject: Re: [RFC 4/4] perf sched schedstat: Add support for report subcommand

On 2024-05-08 at 11:34:27 +0530, Ravi Bangoria wrote:
> From: Swapnil Sapkal <swapnil.sapkal@....com>
> 
> `perf sched schedstat record` captures two sets of samples. For workload
> profile, first set right before workload starts and second set after
> workload finishes. For the systemwide profile, first set at the beginning
> of profile and second set on receiving SIGINT signal.
> 
> Add `perf sched schedstat report` subcommand that will read both the set
> of samples, get the diff and render a final report. Final report prints
> scheduler stat at cpu granularity as well as sched domain granularity.
> 
> Usage example:
> 
>   # perf sched schedstat record
>   # perf sched schedstat report
> 
> Co-developed-by: Ravi Bangoria <ravi.bangoria@....com>
> Signed-off-by: Swapnil Sapkal <swapnil.sapkal@....com>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@....com>
>

I've tested it on a 240 CPUs Xeon system and it looks very useful. Thanks!

1. Just to confirm, if we want to add new fields for debugging purpose,
   schedstat-domain-v1x.h and schedstat-cpu-v1x.h are the only files to
   be touched, right?
2. Although we can filter the output, is it applicable to only track some
   CPUs? Like perf sched schedstat -C 4 record

thanks,
Chenyu