linux-kernel - RE: RE: [PATCH v5] platform/x86: dell-laptop: Implement platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 11 May 2024 15:05:15 +0000
From: "Shen, Yijun" <Yijun.Shen@...l.com>
To: Mario Limonciello <mario.limonciello@....com>,
        Lyndon Sanche
	<lsanche@...deno.ca>
CC: "pali@...nel.org" <pali@...nel.org>, "W_Armin@....de" <W_Armin@....de>,
        "srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
        "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
        "lkp@...el.com" <lkp@...el.com>, Hans de Goede <hdegoede@...hat.com>,
        Matthew
 Garrett <mjg59@...f.ucam.org>,
        Jonathan Corbet <corbet@....net>,
        Heiner
 Kallweit <hkallweit1@...il.com>,
        Vegard Nossum <vegard.nossum@...cle.com>,
        "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dell Client
 Kernel <Dell.Client.Kernel@...l.com>
Subject: RE: RE: [PATCH v5] platform/x86: dell-laptop: Implement
 platform_profile


Internal Use - Confidential
> -----Original Message-----
> From: Mario Limonciello <mario.limonciello@....com>
> Sent: Wednesday, May 8, 2024 11:53 PM
> To: Shen, Yijun <Yijun_Shen@...l.com>; Lyndon Sanche
> <lsanche@...deno.ca>
> Cc: pali@...nel.org; W_Armin@....de;
> srinivas.pandruvada@...ux.intel.com; ilpo.jarvinen@...ux.intel.com;
> lkp@...el.com; Hans de Goede <hdegoede@...hat.com>; Matthew Garrett
> <mjg59@...f.ucam.org>; Jonathan Corbet <corbet@....net>; Heiner Kallweit
> <hkallweit1@...il.com>; Vegard Nossum <vegard.nossum@...cle.com>;
> platform-driver-x86@...r.kernel.org; linux-kernel@...r.kernel.org; Dell Client
> Kernel <Dell.Client.Kernel@...l.com>
> Subject: Re: RE: [PATCH v5] platform/x86: dell-laptop: Implement
> platform_profile
>
>
> [EXTERNAL EMAIL]
>
> On 5/8/2024 09:24, Shen, Yijun wrote:
> > Hi Lyndon,
> >
> >   Thanks for working on this patch.
> >
> >>
> >   Dell side has an initial testing with this patch on some laptops, it looks
> good. While changing the platform profile:
> > 1. The corresponding USTT option in BIOS will be changed.
> > 2. thermald will not be impacted. The related PSVT and ITMT will be loaded.
> >   Some Dell DTs does not have the USTT, Dell'll have a check if nothing is
> broken.
>
> Hi Alex!
>
> Have you had a check both on both your AMD laptops and workstations too,
> or just the Intel ones?  I think it would be good to make sure it's getting the
> correct experience in both cases.
>
Hi Mario,

 I've a check for this, for both laptop and workstation, the dell_laptop module will not be loaded. So, AMD platform will not be impacted by this patch series.
Follow is one example output with workstation.
 #lsmod | grep dell
   dell_wmi               28672  0
   dell_smbios            32768  1 dell_wmi
   dcdbas                 20480  1 dell_smbios
   dell_wmi_descriptor    20480  2 dell_wmi,dell_smbios
   sparse_keymap          12288  1 dell_wmi
   ledtrig_audio          12288  3 snd_ctl_led,snd_hda_codec_generic,dell_wmi
   video                  73728  2 dell_wmi,nvidia_modeset
   wmi                    40960  5 video,dell_wmi,wmi_bmof,dell_smbios,dell_wmi_descriptor

> >
> >    Additional, with this patch, follow behavior is found:
> >   1. For example, the platform profile is quiet.
> >   2. Reboot the system and change the USTT to performance.
> >   3. Boot to desktop, the platform profile is "quiet", the USTT will be
> changed back to "quiet".
> >   This looks like not a proper user experience. The platform profile should
> honor the BIOS setting, aka, the platform profile should be switched to
> "performance".
> >
>
> I agree, this sounds like the initial profile needs to be read from the BIOS
> settings too.
>
> Furthermore I wanted to ask is there also a WMI setting that corresponds to
> this that dell-wmi-sysman offers?
 Yes, Mario, you're right. This thermal setting could also be toggled by dell-wmi-sysman.
But, for the Dell consumer AMD laptops, like Alienware, the BIOS is another variant which is different with the workstation one.
With this variant BIOS, there is no USTT and also no dell_wmi/dell-wmi-sysman.

> I'm wondering if both should be probed in case the SMBIOS one goes away one day.
 Yep, I think this is a good suggestion.

>
> It seems like maybe ThermalManagement corresponds.  There was some test
> data in fwupd for it:
>
> https://urldefense.com/v3/__https://github.com/fwupd/fwupd/tree/main/lib
> fwupdplugin/tests/bios-attrs/dell-xps13-9310/dell-wmi-
> sysman/attributes/ThermalManagement__;!!LpKI!iyfGSyfnGxLymc-
> cEg93dfcnBIOtTJbfmCckZlj46eGqvJ_pHJ7WqFZ7-
> zrklKWKkZifqNgJ13LFm6wuz2UlzYqMPXciVw$ [github[.]com]