linux-kernel - Re: [PATCH] drm/i915: Correct error handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA1PR22MB5493FEAD09C01811F539A9D6AEE02@SA1PR22MB5493.namprd22.prod.outlook.com>
Date: Sat, 11 May 2024 15:36:22 +0000
From: Jiasheng Jiang <jian1000@...due.edu>
To: "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>,
	"joonas.lahtinen@...ux.intel.com" <joonas.lahtinen@...ux.intel.com>,
	"rodrigo.vivi@...el.com" <rodrigo.vivi@...el.com>, "tursulin@...ulin.net"
	<tursulin@...ulin.net>, "airlied@...il.com" <airlied@...il.com>,
	"daniel@...ll.ch" <daniel@...ll.ch>, "chris@...is-wilson.co.uk"
	<chris@...is-wilson.co.uk>
CC: "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/i915: Correct error handler

Maybe the format is incorrect. I would like to use "jiashengjiangcool@...look.com" to resend my patch.

-Jiasheng

________________________________________
From: Jiasheng Jiang
Sent: Saturday, May 11, 2024 3:40
To: jani.nikula@...ux.intel.com; joonas.lahtinen@...ux.intel.com; rodrigo.vivi@...el.com; tursulin@...ulin.net; airlied@...il.com; daniel@...ll.ch; chris@...is-wilson.co.uk
Cc: intel-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org
Subject: [PATCH] drm/i915: Correct error handler

Replace "slab_priorities" with "slab_dependencies" in the error handler
to avoid memory leak.

Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global")
Signed-off-by: Jiasheng Jiang <jiasheng@...due.edu>
---
 drivers/gpu/drm/i915/i915_scheduler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c
index 762127dd56c5..70a854557e6e 100644
--- a/drivers/gpu/drm/i915/i915_scheduler.c
+++ b/drivers/gpu/drm/i915/i915_scheduler.c
@@ -506,6 +506,6 @@ int __init i915_scheduler_module_init(void)
        return 0;

 err_priorities:
-       kmem_cache_destroy(slab_priorities);
+       kmem_cache_destroy(slab_dependencies);
        return -ENOMEM;
 }
--
2.25.1