linux-kernel - Re: [PATCH] iio:proximity:hx9031as: Add TYHX HX9031AS/HX9023S sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 12 May 2024 03:18:40 +0800
From: kernel test robot <lkp@...el.com>
To: Yasin Lee <yasin.lee.x@...look.com>, jic23@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, lars@...afoo.de, swboyd@...omium.org,
	nuno.a@...log.com, andy.shevchenko@...il.com,
	u.kleine-koenig@...gutronix.de, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, yasin.lee.x@...il.com,
	yasin.lee.x@...look.com
Subject: Re: [PATCH] iio:proximity:hx9031as: Add TYHX HX9031AS/HX9023S sensor
 driver

Hi Yasin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.9-rc7 next-20240510]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yasin-Lee/iio-proximity-hx9031as-Add-TYHX-HX9031AS-HX9023S-sensor-driver/20240510-173839
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/SN7PR12MB8101EDFA7F91A59761095A28A4E72%40SN7PR12MB8101.namprd12.prod.outlook.com
patch subject: [PATCH] iio:proximity:hx9031as: Add TYHX HX9031AS/HX9023S sensor driver
config: arc-randconfig-r133-20240512 (https://download.01.org/0day-ci/archive/20240512/202405120334.eHnXGJwn-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20240512/202405120334.eHnXGJwn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405120334.eHnXGJwn-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/iio/proximity/hx9031as.c:1919:21: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __be16 [usertype] val @@     got signed int @@
   drivers/iio/proximity/hx9031as.c:1919:21: sparse:     expected restricted __be16 [usertype] val
   drivers/iio/proximity/hx9031as.c:1919:21: sparse:     got signed int
   drivers/iio/proximity/hx9031as.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/umh.h, include/linux/kmod.h, ...):
   include/linux/page-flags.h:242:46: sparse: sparse: self-comparison always evaluates to false
   include/linux/page-flags.h:242:46: sparse: sparse: self-comparison always evaluates to false

vim +1919 drivers/iio/proximity/hx9031as.c

  1902	
  1903	static irqreturn_t hx9031as_trigger_handler(int irq, void *private)
  1904	{
  1905		struct iio_poll_func *pf = private;
  1906		struct iio_dev *indio_dev = pf->indio_dev;
  1907		struct hx9031as_data *data = iio_priv(indio_dev);
  1908		__be16 val;
  1909		int bit = 0;
  1910		int ii = 0;
  1911	
  1912		ENTER;
  1913		mutex_lock(&data->mutex);
  1914	
  1915		hx9031as_sample();
  1916		hx9031as_get_prox_state();
  1917	
  1918		for_each_set_bit(bit, indio_dev->active_scan_mask, indio_dev->masklength) {
> 1919			val = hx9031as_pdata.diff[indio_dev->channels[bit].channel];
  1920			data->buffer.channels[ii++] = val;
  1921			PRINT_INF("bit=%d, ii=%d, val=%d\n", bit, ii - 1, val);
  1922		}
  1923	
  1924		iio_push_to_buffers_with_timestamp(indio_dev, &data->buffer, pf->timestamp);
  1925		mutex_unlock(&data->mutex);
  1926	
  1927		iio_trigger_notify_done(indio_dev->trig);
  1928		return IRQ_HANDLED;
  1929	}
  1930	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki