linux-kernel - RE: [EXTERNAL] Re: [PATCH v4 1/3] ALSA: ASoc/tas2781: Fix wrong loading calibrated data sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <efb9d840f44c477d88f06e3f03d06f7b@ti.com>
Date: Sat, 11 May 2024 03:35:05 +0000
From: "Ding, Shenghao" <shenghao-ding@...com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: "broonie@...nel.org" <broonie@...nel.org>,
        "lgirdwood@...il.com"
	<lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "pierre-louis.bossart@...ux.intel.com"
	<pierre-louis.bossart@...ux.intel.com>,
        "13916275206@....com"
	<13916275206@....com>,
        "alsa-devel@...a-project.org"
	<alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "liam.r.girdwood@...el.com"
	<liam.r.girdwood@...el.com>,
        "bard.liao@...el.com" <bard.liao@...el.com>,
        "yung-chuan.liao@...ux.intel.com" <yung-chuan.liao@...ux.intel.com>,
        "Lu,
 Kevin" <kevin-lu@...com>,
        "cameron.berkenpas@...il.com"
	<cameron.berkenpas@...il.com>,
        "tiwai@...e.de" <tiwai@...e.de>, "Xu, Baojun"
	<baojun.xu@...com>,
        "soyer@....hu" <soyer@....hu>,
        "Baojun.Xu@....com"
	<Baojun.Xu@....com>
Subject: RE: [EXTERNAL] Re: [PATCH v4 1/3] ALSA: ASoc/tas2781: Fix wrong
 loading calibrated data sequence



> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Friday, May 10, 2024 11:13 PM
> To: Ding, Shenghao <shenghao-ding@...com>
> Cc: broonie@...nel.org; lgirdwood@...il.com; perex@...ex.cz; pierre-
> louis.bossart@...ux.intel.com; 13916275206@....com; alsa-devel@...a-
> project.org; linux-kernel@...r.kernel.org; liam.r.girdwood@...el.com;
> bard.liao@...el.com; yung-chuan.liao@...ux.intel.com; Lu, Kevin <kevin-
> lu@...com>; cameron.berkenpas@...il.com; tiwai@...e.de; Xu, Baojun
> <baojun.xu@...com>; soyer@....hu; Baojun.Xu@....com
> Subject: [EXTERNAL] Re: [PATCH v4 1/3] ALSA: ASoc/tas2781: Fix wrong loading
> calibrated data sequence
> 
> On Fri, May 10, 2024 at 11: 41: 19AM +0800, Shenghao Ding wrote: > Calibrated
> data will be set to default after loading DSP config params, > which will cause
> speaker protection work abnormally. Reload calibrated > data after loading
> ZjQcmQRYFpfptBannerStart This message was sent from outside of Texas
> Instruments.
> Do not click links or open attachments unless you recognize the source of this
> email and know the content is safe. If you wish to report this message to IT
> Security, please forward the message as an attachment to phishing@...t.ti.com
> 
> ZjQcmQRYFpfptBannerEnd
> On Fri, May 10, 2024 at 11:41:19AM +0800, Shenghao Ding wrote:
> > Calibrated data will be set to default after loading DSP config
> > params, which will cause speaker protection work abnormally. Reload
> > calibrated data after loading DSP config params.
> >
> > Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver")
> 
> How on earth this can be a fix?..
Removing the declaration of tasdevice_prmg_calibdata_load is a part of fix.
Loading calibrated data after loading dsp program become a redundance.
> 
> > -// Copyright (C) 2022 - 2023 Texas Instruments Incorporated
> > +// Copyright (C) 2022 - 2024 Texas Instruments Incorporated
> 
...
> > -int tasdevice_prmg_calibdata_load(void *context, int prm_no);
> 
> --
> With Best Regards,
> Andy Shevchenko
>