linux-kernel - Re: [PATCH v7 2/6] iommu/arm-smmu-v3: Issue a batch of commands to the same cmdq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZkDhb5ZmymmT2+64@nvidia.com>
Date: Sun, 12 May 2024 12:34:07 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: will@...nel.org, robin.murphy@....com, joro@...tes.org,
	thierry.reding@...il.com, vdumpa@...dia.com, jonathanh@...dia.com,
	linux-kernel@...r.kernel.org, iommu@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v7 2/6] iommu/arm-smmu-v3: Issue a batch of commands to
 the same cmdq

On Tue, May 07, 2024 at 10:56:50PM -0700, Nicolin Chen wrote:
> The driver calls in different places the arm_smmu_get_cmdq() helper, and
> it's fine to do so since the helper always returns the single SMMU CMDQ.
> However, with NVIDIA CMDQV extension or SMMU ECMDQ, there can be multiple
> cmdqs in the system to select one from. And either case requires a batch
> of commands to be issued to the same cmdq. Thus, a cmdq has to be decided
> in the higher-level callers.
> 
> Add a cmdq pointer in arm_smmu_cmdq_batch structure, and decide the cmdq
> when initializing the batch. Pass it down to the bottom function. Update
> __arm_smmu_cmdq_issue_cmd() accordingly for single command issuers.
> 
> Suggested-by: Jason Gunthorpe <jgg@...dia.com>
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> ---
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 44 +++++++++++++--------
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h |  1 +
>  2 files changed, 29 insertions(+), 16 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason