linux-kernel - Re: [PATCH] eventfs: Directly return NULL to avoid null point dereferenced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34c7ffeb-1fe9-4e89-a7b6-c6a8be17df90@web.de>
Date: Sun, 12 May 2024 19:12:20 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Hao Ge <gehao@...inos.cn>, linux-trace-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Hao Ge <hao.ge@...ux.dev>
Subject: Re: [PATCH] eventfs: Directly return NULL to avoid null point
 dereferenced

> When the condition ei->is_free holds,we return NULL directly to
> avoid update_events_attr to use NULL point about ei.

* Please avoid typos in the summary phrase and the commit message.

* Would you like to use an imperative wording for an improved change description?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc7#n94


…
> +++ b/fs/tracefs/event_inode.c
> @@ -346,8 +346,7 @@ static struct eventfs_inode *eventfs_find_events(struct dentry *dentry)
>  		 * doesn't matter.
>  		 */
>  		if (ei->is_freed) {
> -			ei = NULL;
> -			break;
> +			return NULL;
>  		}
…

How do you think about to omit curly brackets here?

Regards,
Markus