linux-kernel - Re: [PATCH] fs/jffs2: Fix NULL deref in jffs2_scan_dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1371873614.97879.1715546347299.JavaMail.zimbra@nod.at>
Date: Sun, 12 May 2024 22:39:07 +0200 (CEST)
From: Richard Weinberger <richard@....at>
To: Artem Chernyshev <artem.chernyshev@...-soft.ru>
Cc: David Woodhouse <dwmw2@...radead.org>, 
	linux-mtd <linux-mtd@...ts.infradead.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] fs/jffs2: Fix NULL deref in jffs2_scan_dirty_space

----- Ursprüngliche Mail -----
> Von: "Artem Chernyshev" <artem.chernyshev@...-soft.ru>
> An: "David Woodhouse" <dwmw2@...radead.org>, "richard" <richard@....at>
> CC: "Artem Chernyshev" <artem.chernyshev@...-soft.ru>, "linux-mtd" <linux-mtd@...ts.infradead.org>, "linux-kernel"
> <linux-kernel@...r.kernel.org>, lvc-project@...uxtesting.org
> Gesendet: Freitag, 29. März 2024 13:16:29
> Betreff: [PATCH] fs/jffs2: Fix NULL deref in jffs2_scan_dirty_space

> As was mentioned in 2ebf09c2, it is possible to get oops,
> when marking space dirty in scan, but no previous node exists
> 
> It still can be in jffs2_link_node_ref() via deref jeb->last_node.
> Since all jffs2_scan_dirty_space() callers check value of a
> function, we can return error code safely.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Artem Chernyshev <artem.chernyshev@...-soft.ru>
> ---
> fs/jffs2/nodelist.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/jffs2/nodelist.c b/fs/jffs2/nodelist.c
> index b86c78d178c6..6bebf1d64000 100644
> --- a/fs/jffs2/nodelist.c
> +++ b/fs/jffs2/nodelist.c
> @@ -669,8 +669,11 @@ int jffs2_scan_dirty_space(struct jffs2_sb_info *c, struct
> jffs2_eraseblock *jeb
> 			size, jeb->free_size, jeb->wasted_size);
> 		BUG();
> 	}
> +	if (!jeb->last_node) {
> +		return -EINVAL;
> +	}

Did you test this change? I'm not so sure whether returning -EINVAL is
correct.

Thanks,
//richard