linux-kernel - Re: [PATCH] integrity: Update comment for load_moklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D181I8W0OB91.2VHONX3BPMPP3@kernel.org>
Date: Mon, 13 May 2024 02:03:59 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Yusong Gao" <a869920004@...il.com>, <zohar@...ux.ibm.com>,
 <roberto.sassu@...wei.com>, <dmitry.kasatkin@...il.com>,
 <eric.snowberg@...cle.com>, <paul@...l-moore.com>, <jmorris@...ei.org>,
 <serge@...lyn.com>
Cc: <linux-integrity@...r.kernel.org>, <keyrings@...r.kernel.org>,
 <linux-security-module@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <trivial@...nel.org>
Subject: Re: [PATCH] integrity: Update comment for load_moklist_certs()

On Sat May 11, 2024 at 6:22 AM EEST, Yusong Gao wrote:
> After commit 45fcd5e521cd ("integrity: add new keyring handler for
> mok keys"), the comment about load_moklist_certs() is out-of-date.
> Change keyring name from platform to machine.
>
> Signed-off-by: Yusong Gao <a869920004@...il.com>
> ---
>  security/integrity/platform_certs/load_uefi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c
> index d1fdd113450a..e954776d3cfb 100644
> --- a/security/integrity/platform_certs/load_uefi.c
> +++ b/security/integrity/platform_certs/load_uefi.c
> @@ -97,7 +97,7 @@ static __init void *get_cert_list(efi_char16_t *name, efi_guid_t *guid,
>   * load_moklist_certs() - Load MokList certs
>   *
>   * Load the certs contained in the UEFI MokListRT database into the
> - * platform trusted keyring.
> + * machine keyring.
>   *
>   * This routine checks the EFI MOK config table first. If and only if
>   * that fails, this routine uses the MokListRT ordinary UEFI variable.

Alone pretty useless change to be honest. Can be fixed up when something
relevant is changed.

BR, Jarkko