linux-kernel - Re: [PATCH v6 1/9] iio: pressure: bmp280: Remove dead error checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 12 May 2024 13:07:06 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: lars@...afoo.de, andriy.shevchenko@...ux.intel.com,
 ang.iglesiasg@...il.com, mazziesaccount@...il.com, ak@...klinger.de,
 petre.rodan@...dimension.ro, phil@...pberrypi.com, 579lpy@...il.com,
 linus.walleij@...aro.org, semen.protsenko@...aro.org,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/9] iio: pressure: bmp280: Remove dead error checks

On Wed,  8 May 2024 18:51:59 +0200
Vasileios Amoiridis <vassilisamir@...il.com> wrote:

> The ret value is being checked already in all the previous
> paths which exit in case of error, so this path can never
> become true.
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
Applied to the togreg branch of iio.git, but only initially pushed out
as testing because I'll be rebasing that branch on 6.10-rc1 in about 2 weeks
time.

Jonathan

> ---
>  drivers/iio/pressure/bmp280-core.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index ed49e0779d41..311a011604da 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -1350,10 +1350,6 @@ static int bmp580_nvm_operation(struct bmp280_data *data, bool is_write)
>  		poll = 50;
>  		timeout = 400;
>  	}
> -	if (ret) {
> -		dev_err(data->dev, "failed to write command sequence\n");
> -		return -EIO;
> -	}
>  
>  	/* Wait until NVM is ready again */
>  	ret = regmap_read_poll_timeout(data->regmap, BMP580_REG_STATUS, reg,
> 
> base-commit: dccb07f2914cdab2ac3a5b6c98406f765acab803
> prerequisite-patch-id: 97b99b1106cbfd65cef8d256e4dc1a3a9257511e
> prerequisite-patch-id: c60e8ef6fae62417c3430b7598b1a3d2a551be79
> prerequisite-patch-id: 6a49484a6d154ddcd1b45b71a6be2c3542ae0be6
> prerequisite-patch-id: 5aae62fa92c719fb65a8701ec4e1c4284bef7fd9
> prerequisite-patch-id: 6943297d5f70f74bfcf5d5b26198423e428773d9