[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240512025040.1276-3-shenghao-ding@ti.com>
Date: Sun, 12 May 2024 10:50:39 +0800
From: Shenghao Ding <shenghao-ding@...com>
To: <broonie@...nel.org>
CC: <andriy.shevchenko@...ux.intel.com>, <lgirdwood@...il.com>,
<perex@...ex.cz>, <pierre-louis.bossart@...ux.intel.com>,
<13916275206@....com>, <alsa-devel@...a-project.org>,
<linux-kernel@...r.kernel.org>, <liam.r.girdwood@...el.com>,
<bard.liao@...el.com>, <yung-chuan.liao@...ux.intel.com>,
<kevin-lu@...com>, <cameron.berkenpas@...il.com>, <tiwai@...e.de>,
<baojun.xu@...com>, <soyer@....hu>, <Baojun.Xu@....com>,
Shenghao Ding <shenghao-ding@...com>
Subject: [PATCH v5 3/3] ASoC: tas2781: Fix wrong loading calibrated data sequence
Use the API with correct sequence instead of the wrong one.
Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver")
Signed-off-by: Shenghao Ding <shenghao-ding@...com>
---
v5:
- correct changelog has no much relationship with the patch
v4:
- Use the the culprit of the bug itself as the fixes tag
v3:
- No changes.
v2:
- In the Subject, fixed --> Fix
- dsp --> DSP
- Add Fixes tag
- Changed the copyright year to 2024 in the related files
v1:
- Download calibrated data after loading the new DSP config params
- Call tasdevice_prmg_load instead of tasdevice_prmg_calibdata_load, it
is unnecessary to load calibrated data after loading DSP program. Load
it after loading DSP config params each time.
---
sound/soc/codecs/tas2781-i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
index b5abff230e43..9350972dfefe 100644
--- a/sound/soc/codecs/tas2781-i2c.c
+++ b/sound/soc/codecs/tas2781-i2c.c
@@ -2,7 +2,7 @@
//
// ALSA SoC Texas Instruments TAS2563/TAS2781 Audio Smart Amplifier
//
-// Copyright (C) 2022 - 2023 Texas Instruments Incorporated
+// Copyright (C) 2022 - 2024 Texas Instruments Incorporated
// https://www.ti.com
//
// The TAS2563/TAS2781 driver implements a flexible and configurable
@@ -414,7 +414,7 @@ static void tasdevice_fw_ready(const struct firmware *fmw,
__func__, tas_priv->cal_binaryname[i]);
}
- tasdevice_prmg_calibdata_load(tas_priv, 0);
+ tasdevice_prmg_load(tas_priv, 0);
tas_priv->cur_prog = 0;
out:
if (tas_priv->fw_state == TASDEVICE_DSP_FW_FAIL) {
--
2.34.1
Powered by blists - more mailing lists