linux-kernel - Re: [PATCH v4 3/3] perf/core: Check sample_type in perf_sample_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cggLpPVEuMAriR7Zk-xNP6_Ecwx-zg5SyM6emvhRwEP+w@mail.gmail.com>
Date: Mon, 13 May 2024 13:39:04 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Yabin Cui <yabinc@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
	bpf@...r.kernel.org
Subject: Re: [PATCH v4 3/3] perf/core: Check sample_type in perf_sample_save_brstack

On Mon, May 13, 2024 at 11:31 AM Yabin Cui <yabinc@...gle.com> wrote:
>
> arch/powerpc/perf/core-book3s.c checks sample_type, see
>    if (event->attr.sample_type & PERF_SAMPLE_BRANCH_STACK) {
>      ...
>      perf_sample_save_brstack(&data, event, &cpuhw->bhrb_stack, NULL);
>   }
> So I think we don't need the "fixes:" line.

Oh, ok.  Thanks for the correction!

Namhyung