linux-kernel - [PATCH] md: Reduce flag condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Mon, 13 May 2024 14:47:00 +0800
From: "Tse-Chia.Chang" <merqqcury@...il.com>
To: snitzer@...nel.org
Cc: agk@...hat.com,
	mpatocka@...hat.com,
	dm-devel@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	"Tse-Chia.Chang" <merqqcury@...il.com>
Subject: [PATCH] md: Reduce flag condition

Clear DM_COPYD_IGNORE_ERROR will have no effect regardless of whether
it is set in the flags. Therefore, this patch reduces one conditional
check.

Signed-off-by: Tse-Chia.Chang <merqqcury@...il.com>
---
 drivers/md/dm-kcopyd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/dm-kcopyd.c b/drivers/md/dm-kcopyd.c
index 6ea75436a..7a21875b1 100644
--- a/drivers/md/dm-kcopyd.c
+++ b/drivers/md/dm-kcopyd.c
@@ -817,8 +817,7 @@ void dm_kcopyd_copy(struct dm_kcopyd_client *kc, struct dm_io_region *from,
 	/*
 	 * If we need to write sequentially, errors cannot be ignored.
 	 */
-	if (job->flags & BIT(DM_KCOPYD_WRITE_SEQ) &&
-	    job->flags & BIT(DM_KCOPYD_IGNORE_ERROR))
+	if (job->flags & BIT(DM_KCOPYD_WRITE_SEQ))
 		job->flags &= ~BIT(DM_KCOPYD_IGNORE_ERROR);
 
 	if (from) {
-- 
2.34.1