linux-kernel - Re: [PATCH] drm/i915: Correct error handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ce1e1097-2e7d-475b-ac17-3b84aec473e2@linux.intel.com>
Date: Mon, 13 May 2024 09:25:45 +0200
From: Nirmoy Das <nirmoy.das@...ux.intel.com>
To: Jiasheng Jiang <jiashengjiangcool@...look.com>,
 jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
 rodrigo.vivi@...el.com, tursulin@...ulin.net, airlied@...il.com,
 daniel@...ll.ch, chris@...is-wilson.co.uk
Cc: intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915: Correct error handler


On 5/11/2024 5:48 PM, Jiasheng Jiang wrote:
> Replace "slab_priorities" with "slab_dependencies" in the error handler to avoid memory leak.

Nice catch. I would make the subject more like:

drm/i915: Fix memory leak by correcting cache object name in error handler

>
> Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global")

Also need Cc: <stable@...r.kernel.org> # v5.2+

With those:

Reviewed-by: Nirmoy Das <nirmoy.das@...el.com>


Nirmoy

> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...look.com>
> ---
>   drivers/gpu/drm/i915/i915_scheduler.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c
> index 762127dd56c5..70a854557e6e 100644
> --- a/drivers/gpu/drm/i915/i915_scheduler.c
> +++ b/drivers/gpu/drm/i915/i915_scheduler.c
> @@ -506,6 +506,6 @@ int __init i915_scheduler_module_init(void)
>   	return 0;
>   
>   err_priorities:
> -	kmem_cache_destroy(slab_priorities);
> +	kmem_cache_destroy(slab_dependencies);
>   	return -ENOMEM;
>   }