linux-kernel - Re: [PATCH AUTOSEL 6.1 08/25] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86zfsum7zm.wl-maz@kernel.org>
Date: Mon, 13 May 2024 09:27:57 +0100
From: Marc Zyngier <maz@...nel.org>
To: Pavel Machek <pavel@...x.de>
Cc: Sasha Levin <sashal@...nel.org>,
	linux-kernel@...r.kernel.org,
	stable@...r.kernel.org,
	Oliver Upton <oliver.upton@...ux.dev>,
	pbonzini@...hat.com,
	shuah@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	kvmarm@...ts.linux.dev,
	kvm@...r.kernel.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 08/25] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF

On Mon, 13 May 2024 09:20:38 +0100,
Pavel Machek <pavel@...x.de> wrote:
> 
> Hi!
> 
> > Assert that accesses to a non-existent vgic-v2 CPU interface
> > consistently fail across the various KVM device attr ioctls. This also
> > serves as a regression test for a bug wherein KVM hits a NULL
> > dereference when the CPUID specified in the ioctl is invalid.
> > 
> > Note that there is no need to print the observed errno, as TEST_ASSERT()
> > will take care of it.
> 
> I don't think this fixes the bug... and thus we should not need it in
> stable.

Given that this goes together with an actually bug fix that was
backported, it *is*, for once, actually useful to have it in stable.

	M.

-- 
Without deviation from the norm, progress is not possible.