linux-kernel - Re: [PATCH] arm64: dts: qcom: sm8550: Move some common usb node settings to SoC dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <829162d0-2fef-4bbc-9417-13e8ca96150c@kernel.org>
Date: Mon, 13 May 2024 10:56:11 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tengfei Fan <quic_tengfan@...cinc.com>, andersson@...nel.org,
 konrad.dybcio@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...cinc.com
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: Move some common usb node
 settings to SoC dtsi

On 13/05/2024 10:47, Tengfei Fan wrote:
> All the board dts which base on SM8550 SoC dtsi refer to usb_1_dwc3_ss,
> usb_dp_qmpphy_usb_ss_in, orientation-switch and usb-role-switch, so move
> them to SoC dtsi from board dts.

That's not really a good argument. Argument is that it is a SoC property
(vs being a property of a board). Provide rationale for that. You are
moving things just because they look common, so to me it looks really
unjustified.

> OTG is default for dr_mode, so it can be dropped from board dts.

Separate patch, see submitting patches.

Best regards,
Krzysztof