linux-kernel - Re: [PATCH v3 1/8] media: qcom: camss: Add per sub-device type resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96a1e5a8-b887-4bb6-b79a-a4d4549c1415@quicinc.com>
Date: Mon, 13 May 2024 12:55:34 +0300
From: "Gjorgji Rosikopulos (Consultant)" <quic_grosikop@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <mchehab@...nel.org>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <laurent.pinchart@...asonboard.com>,
        <hverkuil-cisco@...all.nl>, <quic_hariramp@...cinc.com>,
        <matti.lehtimaki@...il.com>
Subject: Re: [PATCH v3 1/8] media: qcom: camss: Add per sub-device type
 resources



On 5/11/2024 1:18 AM, Bryan O'Donoghue wrote:
> On 11/04/2024 13:45, Gjorgji Rosikopulos wrote:
>> +        .type = CAMSS_SUBDEV_TYPE_CSIPHY,
> 
> As Matti pointed out to me on IRC, the .type value here isn't populated
> in the rest of the 8280xp resources.
> 
> I completely missed that but, then again this appears to be a dead field
> in this series so it makes no difference if it is populated.
> 
> I realise it is probably of use in code you _haven't_ yet published but,
> for now I think we should drop this field, since its dead code.

Yes that is correct i miss that as well.

> 
> I'll send a fixup patch for this, I don't think there's a need for you
> to send the whole series again.

Thank you for this.

~Gjorgji

> 
> ---
> bod