[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAM5zL5qx06f7v-fEXRT1=dZ2s=Vo5eske2GrcMubf2ZuPFJ7mA@mail.gmail.com>
Date: Mon, 13 May 2024 12:39:02 +0200
From: Paweł Anikiel <panikiel@...gle.com>
To: Rob Herring <robh@...nel.org>
Cc: airlied@...il.com, akpm@...ux-foundation.org, conor+dt@...nel.org,
daniel@...ll.ch, dinguyen@...nel.org, hverkuil-cisco@...all.nl,
krzysztof.kozlowski+dt@...aro.org, maarten.lankhorst@...ux.intel.com,
mchehab@...nel.org, mripard@...nel.org, tzimmermann@...e.de,
devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
chromeos-krk-upstreaming@...gle.com
Subject: Re: [PATCH v3 09/10] media: dt-bindings: Add Intel Displayport RX IP
On Fri, May 10, 2024 at 11:24 PM Rob Herring <robh@...nel.org> wrote:
>
> On Tue, May 07, 2024 at 03:54:12PM +0000, Paweł Anikiel wrote:
> > Add dt binding for the Intel Displayport receiver FPGA IP.
> > It is a part of the DisplayPort Intel FPGA IP Core, and supports
> > DisplayPort 1.4, HBR3 video capture and Multi-Stream Transport.
> >
> > The user guide can be found here:
> > https://www.intel.com/programmable/technical-pdfs/683273.pdf
> >
> > Signed-off-by: Paweł Anikiel <panikiel@...gle.com>
> > ---
> > .../devicetree/bindings/media/intel,dprx.yaml | 172 ++++++++++++++++++
> > 1 file changed, 172 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/intel,dprx.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/intel,dprx.yaml b/Documentation/devicetree/bindings/media/intel,dprx.yaml
> > new file mode 100644
> > index 000000000000..01bed858f746
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/intel,dprx.yaml
> > @@ -0,0 +1,172 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/intel,dprx.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Intel DisplayPort RX IP
> > +
> > +maintainers:
> > + - Paweł Anikiel <panikiel@...gle.com>
> > +
> > +description: |
> > + The Intel Displayport RX IP is a part of the DisplayPort Intel FPGA IP
> > + Core. It implements a DisplayPort 1.4 receiver capable of HBR3 video
> > + capture and Multi-Stream Transport.
> > +
> > + The IP features a large number of configuration parameters, found at:
> > + https://www.intel.com/content/www/us/en/docs/programmable/683273/23-3-20-0-1/sink-parameters.html
> > +
> > + The following parameters have to be enabled:
> > + - Support DisplayPort sink
> > + - Enable GPU control
> > + The following parameters have to be set in the devicetree:
> > + - RX maximum link rate (using link-frequencies)
> > + - Maximum lane count (using data-lanes)
> > + - Support MST (using multi-stream-support)
> > + - Max stream count (inferred from the number of ports)
> > +
> > +properties:
> > + compatible:
> > + const: intel,dprx-20.0.1
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + ports:
> > + $ref: /schemas/graph.yaml#/properties/ports
> > +
> > + properties:
> > + port@0:
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + description: MST virtual channel 0 or SST main link
> > +
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > +
> > + properties:
> > + link-frequencies: true
> > +
> > + data-lanes:
> > + minItems: 1
> > + maxItems: 4
> > +
> > + multi-stream-support: true
> > +
> > + required:
> > + - data-lanes
> > + - link-frequencies
> > +
> > + port@1:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: MST virtual channel 0 or SST main link
>
> How can port@0 also be "MST virtual channel 0 or SST main link"?
Sorry, I made a mistake. port@0 should be something like "Input port".
>
> > +
> > + port@2:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: MST virtual channel 1
> > +
> > + port@3:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: MST virtual channel 2
> > +
> > + port@4:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: MST virtual channel 3
> > +
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + dp-receiver@...62000 {
> > + compatible = "intel,dprx-20.0.1";
> > + reg = <0xc0062000 0x800>;
> > + interrupt-parent = <&dprx_mst_irq>;
> > + interrupts = <0 IRQ_TYPE_EDGE_RISING>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
> > + dprx_mst_in: endpoint {
> > + remote-endpoint = <&dp_input_mst_0>;
> > + data-lanes = <0 1 2 3>;
> > + link-frequencies = /bits/ 64 <1620000000 2700000000
> > + 5400000000 8100000000>;
> > + multi-stream-support;
> > + };
> > + };
> > +
> > + port@1 {
> > + reg = <1>;
> > + dprx_mst_0: endpoint {
> > + remote-endpoint = <&video_mst0_0>;
> > + };
> > + };
> > +
> > + port@2 {
> > + reg = <2>;
> > + dprx_mst_1: endpoint {
> > + remote-endpoint = <&video_mst1_0>;
> > + };
> > + };
> > +
> > + port@3 {
> > + reg = <3>;
> > + dprx_mst_2: endpoint {
> > + remote-endpoint = <&video_mst2_0>;
> > + };
> > + };
> > +
> > + port@4 {
> > + reg = <4>;
> > + dprx_mst_3: endpoint {
> > + remote-endpoint = <&video_mst3_0>;
> > + };
> > + };
> > + };
> > + };
> > +
> > + - |
> > + dp-receiver@...64000 {
> > + compatible = "intel,dprx-20.0.1";
> > + reg = <0xc0064000 0x800>;
> > + interrupt-parent = <&dprx_sst_irq>;
> > + interrupts = <0 IRQ_TYPE_EDGE_RISING>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
> > + dprx_sst_in: endpoint {
> > + remote-endpoint = <&dp_input_sst_0>;
> > + data-lanes = <0 1 2 3>;
> > + link-frequencies = /bits/ 64 <1620000000 2700000000
> > + 5400000000 8100000000>;
> > + };
> > + };
> > +
> > + port@1 {
> > + reg = <1>;
> > + dprx_sst_0: endpoint {
> > + remote-endpoint = <&video_sst_0>;
> > + };
> > + };
> > + };
> > + };
> > --
> > 2.45.0.rc1.225.g2a3ae87e7f-goog
> >
Powered by blists - more mailing lists