linux-kernel - RE: [PATCH v2 07/20] pinctrl: renesas: Use scope based of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 13 May 2024 12:04:09 +0000
From: Peng Fan <peng.fan@....com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>
CC: Linus Walleij <linus.walleij@...aro.org>, Thierry Reding
	<thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, Dvorkin
 Dmitry <dvorkin@...bo.com>, Wells Lu <wellslutw@...il.com>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Emil Renner Berthing <kernel@...il.dk>, Jianlong Huang
	<jianlong.huang@...rfivetech.com>, Hal Feng <hal.feng@...rfivetech.com>,
	Orson Zhai <orsonzhai@...il.com>, Baolin Wang
	<baolin.wang@...ux.alibaba.com>, Chunyan Zhang <zhang.lyra@...il.com>, Viresh
 Kumar <vireshk@...nel.org>, Shiraz Hashim <shiraz.linux.kernel@...il.com>,
	"soc@...nel.org" <soc@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>, Alim Akhtar
	<alim.akhtar@...sung.com>, Geert Uytterhoeven <geert+renesas@...der.be>,
	Patrice Chotard <patrice.chotard@...s.st.com>, Heiko Stuebner
	<heiko@...ech.de>, Damien Le Moal <dlemoal@...nel.org>, Ludovic Desroches
	<ludovic.desroches@...rochip.com>, Nicolas Ferre
	<nicolas.ferre@...rochip.com>, Alexandre Belloni
	<alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
	Aisheng Dong <aisheng.dong@....com>, Fabio Estevam <festevam@...il.com>,
	Shawn Guo <shawnguo@...nel.org>, Jacky Bai <ping.bai@....com>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Chester Lin <chester62515@...il.com>,
	Matthias Brugger <mbrugger@...e.com>, "Ghennadi Procopciuc (OSS)"
	<ghennadi.procopciuc@....nxp.com>, Sean Wang <sean.wang@...nel.org>, Matthias
 Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, Sascha Hauer
	<s.hauer@...gutronix.de>, Andrew Jeffery <andrew@...econstruct.com.au>, Joel
 Stanley <joel@....id.au>, Dan Carpenter <dan.carpenter@...aro.org>, Tony
 Lindgren <tony@...mide.com>, Stephen Warren <swarren@...dotorg.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>,
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "openbmc@...ts.ozlabs.org"
	<openbmc@...ts.ozlabs.org>
Subject: RE: [PATCH v2 07/20] pinctrl: renesas: Use scope based of_node_put()
 cleanups

> Subject: Re: [PATCH v2 07/20] pinctrl: renesas: Use scope based
> of_node_put() cleanups
> 
> Hi Peng,
> 
> On Sat, May 4, 2024 at 3:14 PM Peng Fan (OSS) <peng.fan@....nxp.com>
> wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > Use scope based of_node_put() cleanup to simplify code.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> 
> Thanks for your patch!
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> > --- a/drivers/pinctrl/renesas/pinctrl-rzn1.c
> > +++ b/drivers/pinctrl/renesas/pinctrl-rzn1.c
> 
> You missed one trivial conversion, presumably because no error handling and
> thus no of_node_put() is involved?

You are right.

> 
> @@ -737,13 +737,12 @@ static int rzn1_pinctrl_parse_groups(struct
> device_node *np,
> 
>  static int rzn1_pinctrl_count_function_groups(struct device_node *np)  {
> -       struct device_node *child;
>         int count = 0;
> 
>         if (of_property_count_u32_elems(np, RZN1_PINS_PROP) > 0)
>                 count++;
> 
> -       for_each_child_of_node(np, child) {
> +       for_each_child_of_node_scoped(np, child) {
>                 if (of_property_count_u32_elems(child, RZN1_PINS_PROP) > 0)
>                         count++;
>         }
> 
> If you prefer not to include this, I will send a small patch myself later.

I would not add it.
If no major comments in this patchset, I will not do a v3. So, please do that
with your follow up patch.

Thanks,
Peng.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds