linux-kernel - Re: [PATCH] regulator: core: fix debugfs creation regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXrJkYYyCM72pYjFwCDbfO3W6HjSTEiMu_M8yH4Wsf9mQ@mail.gmail.com>
Date: Mon, 13 May 2024 14:17:37 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Johan Hovold <johan+linaro@...nel.org>
Cc: Mark Brown <broonie@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org, 
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] regulator: core: fix debugfs creation regression

On Thu, May 9, 2024 at 3:34 PM Johan Hovold <johan+linaro@...nel.org> wrote:
> regulator_get() may sometimes be called more than once for the same
> consumer device, something which before commit dbe954d8f163 ("regulator:
> core: Avoid debugfs: Directory ...  already present! error") resulted in
> errors being logged.
>
> A couple of recent commits broke the handling of such cases so that
> attributes are now erroneously created in the debugfs root directory the
> second time a regulator is requested and the log is filled with errors
> like:
>
>         debugfs: File 'uA_load' in directory '/' already present!
>         debugfs: File 'min_uV' in directory '/' already present!
>         debugfs: File 'max_uV' in directory '/' already present!
>         debugfs: File 'constraint_flags' in directory '/' already present!
>
> on any further calls.
>
> Fixes: 2715bb11cfff ("regulator: core: Fix more error checking for debugfs_create_dir()")
> Fixes: 08880713ceec ("regulator: core: Streamline debugfs operations")
> Cc: stable@...r.kernel.org
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>

FTR,
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds