linux-kernel - Re: [PATCH] ASoC: intel: Constify struct snd_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88e6bbe3-94a2-4b50-b462-eb27376698c4@linux.intel.com>
Date: Mon, 13 May 2024 08:41:55 -0500
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Cezary Rojewski <cezary.rojewski@...el.com>,
 Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
 Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
 Bard Liao <yung-chuan.liao@...ux.intel.com>,
 Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
 Kai Vehmanen <kai.vehmanen@...ux.intel.com>, Mark Brown
 <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 alsa-devel@...a-project.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH] ASoC: intel: Constify struct snd_soc_ops



On 5/11/24 13:42, Christophe JAILLET wrote:
> Constifying "struct snd_soc_ops" moves some data to a read-only section, so
> increase overall security.
> 
> This structure is also part of scripts/const_structs.checkpatch.
> 
> As an example, on a x86_64, with allmodconfig:
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    6315	   3696	      0	  10011	   271b	sound/soc/intel/boards/ehl_rt5660.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    6379	   3648	      0	  10027	   272b	sound/soc/intel/boards/ehl_rt5660.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only.
> 
> I hope that it can be applied with this single patch because all files are
> in sound/soc/intel/boards/

Doesn't apply for me, can you rebase and resend?

CONFLICT (content): Merge conflict in
sound/soc/intel/boards/sof_maxim_common.h
Auto-merging sound/soc/intel/boards/sof_maxim_common.c
CONFLICT (content): Merge conflict in
sound/soc/intel/boards/sof_maxim_common.c
error: Failed to merge in the changes.

Probably a result of all the changes in this directory...
Thanks!