| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <171560955084.1690511.16227061715514007364.kvalo@kernel.org> Date: Mon, 13 May 2024 14:12:32 +0000 (UTC) From: Kalle Valo <kvalo@...nel.org> To: Jeff Johnson <quic_jjohnson@...cinc.com> Cc: Jeff Johnson <jjohnson@...nel.org>, <linux-wireless@...r.kernel.org>, <ath12k@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, <ath11k@...ts.infradead.org>, Jeff Johnson <quic_jjohnson@...cinc.com> Subject: Re: [PATCH 1/2] wifi: ath12k: initialize 'ret' in ath12k_qmi_load_file_target_mem() Jeff Johnson <quic_jjohnson@...cinc.com> wrote: > smatch flagged the following issue: > > drivers/net/wireless/ath/ath12k/qmi.c:2619 ath12k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'. > > The reality is that 'ret' is initialized in every path through > ath12k_qmi_load_file_target_mem() except one, the case where the input > 'len' is 0, and hence the "while (remaining)" loop is never entered. > But to make sure this case is also handled, add an initializer to the > declaration of 'ret'. > > No functional changes, compile tested only. > > Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com> 2 patches applied to ath-next branch of ath.git, thanks. bb0b0a6b96e6 wifi: ath12k: initialize 'ret' in ath12k_qmi_load_file_target_mem() 199f149e97dc wifi: ath11k: initialize 'ret' in ath11k_qmi_load_file_target_mem() -- https://patchwork.kernel.org/project/linux-wireless/patch/20240504-qmi_load_file_target_mem-v1-1-069fc44c45eb@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists