linux-kernel - Re: [PATCH v2 2/2] Add dp PHY dt-bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f4f85f0b-49eb-4fba-ac76-2df845571b12@kernel.org>
Date: Mon, 13 May 2024 16:17:31 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: LIANKUN YANG (杨连坤) <Liankun.Yang@...iatek.com>,
 "robh+dt@...nel.org" <robh+dt@...nel.org>,
 Chunfeng Yun (云春峰) <Chunfeng.Yun@...iatek.com>,
 "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
 Mac Shen (沈俊) <Mac.Shen@...iatek.com>,
 "tzimmermann@...e.de" <tzimmermann@...e.de>,
 "mripard@...nel.org" <mripard@...nel.org>,
 Jitao Shi (石记涛) <jitao.shi@...iatek.com>,
 "daniel@...ll.ch" <daniel@...ll.ch>,
 "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
 "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "kishon@...nel.org" <kishon@...nel.org>,
 "airlied@...il.com" <airlied@...il.com>,
 "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
 "vkoul@...nel.org" <vkoul@...nel.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 Project_Global_Chrome_Upstream_Group
 <Project_Global_Chrome_Upstream_Group@...iatek.com>,
 "angelogioacchino.delregno@...labora.com"
 <angelogioacchino.delregno@...labora.com>
Cc: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] Add dp PHY dt-bindings

On 13/05/2024 16:15, LIANKUN YANG (杨连坤) wrote:
> On Mon, 2024-05-13 at 08:37 +0200, Krzysztof Kozlowski wrote:
>>  	 
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>  On 10/05/2024 13:04, Liankun Yang wrote:
>>> Add dp PHY dt-bindings.
>>
>> This tells me nothing. Read submitting patches.
>>
>>>
>>> Changeds in v2:
>>
>> This does goes to changelog, not commit log.
>>
>>> - Add dp PHY dt-bindings.
>>> https://patchwork.kernel.org/project/linux-mediatek/patch/
>>> 20240403040517.3279-1-liankun.yang@...iatek.com/
>>>
>>> Signed-off-by: Liankun Yang <liankun.yang@...iatek.com>
>>
>> This patch looks terrible... there's so many wrong things I don't
>> even
>> know where to start.
>>
>> Please use subject prefixes matching the subsystem. You can get them
>> for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the
>> directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>>
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. Then
>> please
>> run `scripts/checkpatch.pl --strict` and (probably) fix more
>> warnings.
>> Some warnings can be ignored, especially from --strict run, but the
>> code
>> here looks like it needs a fix. Feel free to get in touch if the
>> warning
>> is not clear.
>>
>>
>>> ---
>>>  .../display/mediatek/mediatek.phy-dp.yaml     | 45
>> +++++++++++++++++++
>>>  1 file changed, 45 insertions(+)
>>>  create mode 100644
>> Documentation/devicetree/bindings/display/mediatek/mediatek.phy-
>> dp.yaml
>>
>> Wrong filename
>>
>>>
>>> diff --git
>> a/Documentation/devicetree/bindings/display/mediatek/mediatek.phy-
>> dp.yaml
>> b/Documentation/devicetree/bindings/display/mediatek/mediatek.phy-
>> dp.yaml
>>> index 000000000000..476bc329363f
>>> --- /dev/null
>>> +++
>> b/Documentation/devicetree/bindings/display/mediatek/mediatek.phy-
>> dp.yaml
>>> @@ -0,0 +1,45 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: 
>> http://devicetree.org/schemas/display/mediatek/mediatek,phy-dp.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: MediaTek Display Port Controller
>>> +
>>> +maintainers:
>>> +  - Mac shen <mac.shen@...iatek.com>
>>> +  - Liankun yang <Liankun.yang@...iatek.com>
>>> +
>>> +description: |
>>> +  Special settings need to be configured by MediaTek DP based on
>> the actual
>>> +  hardware situation. For example, when using a certain brand's
>> docking
>>> +  station for display projection, garbage may appear. Adjusting
>> the specific
>>> +  ssc value can resolve this issue.
>>> +
>>> +properties:
>>> +  status: disabled
>>
>> I think you nicely shocked Rob already.
>>
>> Please reach internally to Mediatek or collaborating companies to get
>> basic training and instructions how to write patches and bindings.
>>
>> Otherwise it is waste of our time. Mediatek is not a small company so
>> there is no excuse in sending such poor quality patches, which would
>> be
>> EASILY spotted by the MOST BASIC review.
>>
>> Best regards,
>> Krzysztof
>>
> 
> I used scripts/checkpatch.pl and fix reported error and warnings.
> I am resumbmitting bindings by the MOST BASIC review.

No, please wait. Who did the basic review of your patch? Who from
Mediatek? Upstream is not a workhorse to use instead of your resources
for the absolute basic stuff... This feels such exploiting.

Best regards,
Krzysztof