linux-kernel - [PATCH v2] drm/i915: Fix memory leak by correcting cache object name in error handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <BYAPR03MB41688E0CA5B01A0017EFD33DADE22@BYAPR03MB4168.namprd03.prod.outlook.com>
Date: Mon, 13 May 2024 14:39:52 +0000
From: Jiasheng Jiang <jiashengjiangcool@...look.com>
To: nirmoy.das@...ux.intel.com,
	jani.nikula@...ux.intel.com,
	joonas.lahtinen@...ux.intel.com,
	rodrigo.vivi@...el.com,
	tursulin@...ulin.net,
	airlied@...il.com,
	daniel@...ll.ch,
	chris@...is-wilson.co.uk
Cc: intel-gfx@...ts.freedesktop.org,
	dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org,
	Jiasheng Jiang <jiashengjiangcool@...look.com>,
	stable@...r.kernel.org,
	Nirmoy Das <nirmoy.das@...el.com>
Subject: [PATCH v2] drm/i915: Fix memory leak by correcting cache object name in error handler

Replace "slab_priorities" with "slab_dependencies" in the error handler
to avoid memory leak.

Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global")
Cc: <stable@...r.kernel.org> # v5.2+
Reviewed-by: Nirmoy Das <nirmoy.das@...el.com>
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...look.com>
---
Changelog:

v1 -> v2:

1. Alter the subject.
---
 drivers/gpu/drm/i915/i915_scheduler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c
index 762127dd56c5..70a854557e6e 100644
--- a/drivers/gpu/drm/i915/i915_scheduler.c
+++ b/drivers/gpu/drm/i915/i915_scheduler.c
@@ -506,6 +506,6 @@ int __init i915_scheduler_module_init(void)
 	return 0;
 
 err_priorities:
-	kmem_cache_destroy(slab_priorities);
+	kmem_cache_destroy(slab_dependencies);
 	return -ENOMEM;
 }
-- 
2.25.1