linux-kernel - Re: [PATCH net-next v3] net: dsa: mv88e6xxx: control mdio bus-id truncation for long paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240513083225.1043f59e@kernel.org>
Date: Mon, 13 May 2024 08:32:25 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Josua Mayer <josua@...id-run.com>
Cc: Florian Fainelli <f.fainelli@...il.com>, Andrew Lunn <andrew@...n.ch>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Mor Nagli
 <mor.nagli@...id-run.com>
Subject: Re: [PATCH net-next v3] net: dsa: mv88e6xxx: control mdio bus-id
 truncation for long paths

On Tue, 7 May 2024 12:03:31 +0000 Josua Mayer wrote:
> > The idea and implementation is reasonable but this could affect other drivers than mv88e6xxx, why not move that logic to mdiobus_register() and tracking the truncation index globally within the MDIO bus layer?  
> Conceptually I agree, it would be nice to have a centralized
> solution to this problem, it probably can occur in multiple places.
> 
> My reasoning is that solving the problem within a single driver
> is a much smaller task, especially for sporadic contributors
> who lack a deep understanding for how all layers interact.
> 
> Perhaps agreeing on a good solution within this driver
> can inform a more general solution to be added later.

I agree with Florian, FWIW. The choice of how to truncate is a bit
arbitrary, if core does it at least it will be consistent.