linux-kernel - Re: [RFC PATCH] workqueue: Fix rescuer task's name truncated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZkJLHtiGb6XM4iMO@slm.duckdns.org>
Date: Mon, 13 May 2024 07:17:18 -1000
From: Tejun Heo <tj@...nel.org>
To: Aaron Tomlin <atomlin@...mlin.com>
Cc: Wenchao Hao <haowenchao2@...wei.com>,
	Lai Jiangshan <jiangshanlai@...il.com>,
	linux-kernel@...r.kernel.org, Wenchao Hao <haowenchao22@...il.com>,
	neelx@...hat.com
Subject: Re: [RFC PATCH] workqueue: Fix rescuer task's name truncated

Hello

On Sat, May 11, 2024 at 03:15:11PM +0100, Aaron Tomlin wrote:
> > @@ -5439,6 +5439,8 @@ static int init_rescuer(struct workqueue_struct *wq)
> >  		return ret;
> >  	}
> >  
> > +	snprintf(rescuer->desc, sizeof(rescuer->desc), "%s", wq->name);

Can you please address the testbot reported warning?

> >  	wq->rescuer = rescuer;
> >  	if (wq->flags & WQ_UNBOUND)
> >  		kthread_bind_mask(rescuer->task, wq_unbound_cpumask);
> > @@ -6289,6 +6291,8 @@ void wq_worker_comm(char *buf, size_t size, struct task_struct *task)
> >  						  worker->desc);
> >  			}
> >  			raw_spin_unlock_irq(&pool->lock);
> > +		} else if (worker->desc[0] != '\0') {
> > +			scnprintf(buf + off, size - off, "-%s", worker->desc);
> >  		}
> >  	}
> >  
> > -- 
> 
> Reviewed-by: Aaron Tomlin <atomlin@...mlin.com>

The patch looks fine to me otherwise.

Thanks.

-- 
tejun