linux-kernel - Re: [PATCH] drm/bridge: Remove a small useless code snippet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c110750a-0a82-42de-9e21-07b8bde57899@linux.dev>
Date: Mon, 13 May 2024 08:32:10 +0800
From: Sui Jingfeng <sui.jingfeng@...ux.dev>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Maxime Ripard <mripard@...nel.org>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Thomas Zimmermann <tzimmermann@...e.de>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: Remove a small useless code snippet

Hi,


On 2024/5/13 05:09, Laurent Pinchart wrote:
> Hi Sui,
>
> Thank you for the patch.
>
> On Sat, May 11, 2024 at 08:42:38PM +0800, Sui Jingfeng wrote:
>> Because the check on the non-existence (encoder == NULL) has already been
>> done in the implementation of drm_bridge_attach() function, and
>> drm_bridge_attach() is called earlier. The driver won't get to check point
>> even if drm_bridge_attach() fails for some reasons, as it will clear the
>> bridge->encoder to NULL and return a negective error code.
> s/negective/negative/
>

Sorry, my bad.


>> Therefore, there is no need to check another again. Remove the redundant
>> codes at the later.
>>
>> Signed-off-by: Sui Jingfeng <sui.jingfeng@...ux.dev>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>
> If you end up sending a second version of this patch, please include all
> similar patches you have sent at the same time in a patch series,
> instead of sending them separately.

I will send a second version to correct spell error and collect and fold them into a series.

By the way, thanks a lot for you time review my patch and thanks a lot for the generous.

So happy be reviewed and its my pleasure to have opportunities to talk with you. Thanks a lot!


>> ---
>>   drivers/gpu/drm/bridge/simple-bridge.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
>> index 28376d0ecd09..3caa918ac2e0 100644
>> --- a/drivers/gpu/drm/bridge/simple-bridge.c
>> +++ b/drivers/gpu/drm/bridge/simple-bridge.c
>> @@ -116,11 +116,6 @@ static int simple_bridge_attach(struct drm_bridge *bridge,
>>   	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
>>   		return 0;
>>   
>> -	if (!bridge->encoder) {
>> -		DRM_ERROR("Missing encoder\n");
>> -		return -ENODEV;
>> -	}
>> -
>>   	drm_connector_helper_add(&sbridge->connector,
>>   				 &simple_bridge_con_helper_funcs);
>>   	ret = drm_connector_init_with_ddc(bridge->dev, &sbridge->connector,

-- 
Best regards,
Sui