linux-kernel - Re: [PATCH v2 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 13 May 2024 13:58:13 -0500
From: Rob Herring <robh@...nel.org>
To: Stefan Wahren <wahrenst@....net>
Cc: Andrea della Porta <andrea.porta@...e.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kamal Dasu <kamal.dasu@...adcom.com>,
	Al Cooper <alcooperx@...il.com>, Eric Anholt <eric@...olt.net>,
	devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: mmc: Add support for BCM2712 SD host
 controller

On Fri, May 10, 2024 at 09:01:33PM +0200, Stefan Wahren wrote:
> Hi Andrea,
> 
> please drop E. Anholt from the recipients. AFAIK she is not interested
> in kernel development anymore.
> 
> Am 10.05.24 um 16:35 schrieb Andrea della Porta:
> > The BCM2712 has an SDHCI capable host interface similar to the one found
> > in other STB chipsets. Add the relevant compatible string and relative
> > example.
> > 
> > Signed-off-by: Andrea della Porta <andrea.porta@...e.com>
> > ---
> >   .../bindings/mmc/brcm,sdhci-brcmstb.yaml      | 23 +++++++++++++++++++
> >   1 file changed, 23 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> > index cbd3d6c6c77f..404b75fa7adb 100644
> > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> > @@ -13,6 +13,10 @@ maintainers:
> >   properties:
> >     compatible:
> >       oneOf:
> > +      - items:
> > +          - enum:
> > +              - brcm,bcm2712-sdhci
> > +          - const: brcm,sdhci-brcmstb
> >         - items:
> >             - enum:
> >                 - brcm,bcm7216-sdhci
> > @@ -114,3 +118,22 @@ examples:
> >         clocks = <&scmi_clk 245>;
> >         clock-names = "sw_sdio";
> >       };
> > +
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    soc {
> > +      #address-cells = <2>;
> > +      #size-cells = <2>;
> Would be nice to have a short explanation in the commit message why this
> is necessary.

That has nothing to do with *this* patch. It's needed because 'reg' is 
dependent on it and the examples default to 1 cell.

In any case, please just drop the example. A new compatible doesn't 
justify another example.

Rob