linux-kernel - Re: [PATCH] ASoC: dt-bindings: ak4118: convert to dt schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240513193823.GA3006391-robh@kernel.org>
Date: Mon, 13 May 2024 14:38:23 -0500
From: Rob Herring <robh@...nel.org>
To: Xiaxi Shen <shenxiaxi26@...il.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org, lgirdwood@...il.com,
	broonie@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	javier.carrasco.cruz@...il.com, skhan@...uxfoundation.org
Subject: Re: [PATCH] ASoC: dt-bindings: ak4118: convert to dt schema

On Sat, May 11, 2024 at 02:46:24PM -0700, Xiaxi Shen wrote:
> Convert ak4118 binding to DT schema
> 
> It passed dt_binding_check and dtbs_check. Let me know
> if you think it should include something else

This doesn't belong in the commit message.

> 
> Signed-off-by: Xiaxi Shen <shenxiaxi26@...il.com>
> ---
>  .../devicetree/bindings/sound/ak4118.txt      | 22 -------
>  .../bindings/sound/asahi-kasei,ak4118.yaml    | 58 +++++++++++++++++++
>  2 files changed, 58 insertions(+), 22 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/ak4118.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak4118.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/ak4118.txt b/Documentation/devicetree/bindings/sound/ak4118.txt
> deleted file mode 100644
> index 6e11a2f7404c..000000000000
> --- a/Documentation/devicetree/bindings/sound/ak4118.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -AK4118 S/PDIF transceiver
> -
> -This device supports I2C mode.
> -
> -Required properties:
> -
> -- compatible : "asahi-kasei,ak4118"
> -- reg : The I2C address of the device for I2C
> -- reset-gpios: A GPIO specifier for the reset pin
> -- irq-gpios: A GPIO specifier for the IRQ pin
> -
> -Example:
> -
> -&i2c {
> -	ak4118: ak4118@13 {
> -		#sound-dai-cells = <0>;
> -		compatible = "asahi-kasei,ak4118";
> -		reg = <0x13>;
> -		reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>
> -		irq-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4118.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4118.yaml
> new file mode 100644
> index 000000000000..abbce999eb30
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4118.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/asahi-kasei,ak4118.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AK4118 S/PDIF transceiver
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +maintainers:
> +  - Liam Girdwood <lgirdwood@...il.com>
> +  - Mark Brown <broonie@...nel.org>
> +  - Rob Herring <robh@...nel.org>
> +  - Krzysztof Kozlowski <krzk+dt@...nel.org>
> +  - Conor Dooley <conor+dt@...nel.org>

Again, should be someone with the h/w or that cares about it.

(If you are new to bindings (or anything else), it would be best to send 
1 patch out and wait for comments before sending more and repeating the 
same problems on multiple ones.

> +
> +properties:
> +  compatible:
> +    const: asahi-kasei,ak4118
> +
> +  reg:
> +    description: The I2C address of the device for I2C
> +    maxItems: 1
> +
> +  "#sound-dai-cells":
> +    const: 0    
> +
> +  reset-gpios:
> +    description: A GPIO specifier for the reset pin
> +    maxItems: 1
> +
> +  irq-gpios:
> +    description: A GPIO specifier for the IRQ pin
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - reset-gpios
> +  - irq-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +   i2c {
> +     #address-cells = <1>;
> +     #size-cells = <0>;
> +     ak4118@13 {

Node names should be generic:

spdif@13

> +       #sound-dai-cells = <0>;
> +       compatible = "asahi-kasei,ak4118";
> +       reg = <0x13>;
> +       reset-gpios = <&gpio 0 0>;
> +       irq-gpios = <&gpio 1 1>;
> +     };
> +   };
> -- 
> 2.34.1
>