[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c9d27e22-b5cd-4995-86fa-3893430d08a8@ti.com>
Date: Tue, 14 May 2024 10:40:03 +0530
From: Aradhya Bhatia <a-bhatia1@...com>
To: Rob Herring <robh@...nel.org>
CC: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
Jyri Sarha
<jyri.sarha@....fi>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Neil Armstrong <neil.armstrong@...aro.org>,
Laurent Pinchart
<Laurent.pinchart@...asonboard.com>,
David Airlie <airlied@...il.com>, Daniel
Vetter <daniel@...ll.ch>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor
Dooley <conor+dt@...nel.org>,
DRI Development List
<dri-devel@...ts.freedesktop.org>,
Devicetree List
<devicetree@...r.kernel.org>,
Linux Kernel List
<linux-kernel@...r.kernel.org>,
Nishanth Menon <nm@...com>, Vignesh
Raghavendra <vigneshr@...com>,
Praneeth Bajjuri <praneeth@...com>, Udit Kumar
<u-kumar1@...com>,
Francesco Dolcini <francesco@...cini.it>,
Alexander
Sverdlin <alexander.sverdlin@...mens.com>,
Randolph Sapp <rs@...com>, Devarsh
Thakkar <devarsht@...com>,
Jayesh Choudhary <j-choudhary@...com>, Jai Luthra
<j-luthra@...com>
Subject: Re: [PATCH 3/4] dt-bindings: display: ti,am65x-dss: Add OLDI
properties for AM625 DSS
On 14/05/24 01:05, Rob Herring wrote:
> On Sun, May 12, 2024 at 01:00:54AM +0530, Aradhya Bhatia wrote:
>> The DSS in AM625 SoC has 2 OLDI TXes. Refer the OLDI schema to add the
>> properties.
>>
>> Signed-off-by: Aradhya Bhatia <a-bhatia1@...com>
>> ---
>> .../bindings/display/ti/ti,am65x-dss.yaml | 136 +++++++++++++++++-
>> 1 file changed, 135 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> index 399d68986326..4aa2de59b32b 100644
>> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> @@ -85,12 +85,30 @@ properties:
>>
>> properties:
>> port@0:
>> - $ref: /schemas/graph.yaml#/properties/port
>> + $ref: /schemas/graph.yaml#/$defs/port-base
>
> You don't need this change. You aren't adding any extra properties.
Alright. I will make the change.
>
>> description:
>> For AM65x DSS, the OLDI output port node from video port 1.
>> For AM625 DSS, the internal DPI output port node from video
>> port 1.
>> For AM62A7 DSS, the port is tied off inside the SoC.
>> + properties:
>> + endpoint@0:
>> + $ref: /schemas/graph.yaml#/properties/endpoint
>> + description:
>> + For AM625 DSS, VP Connection to OLDI0.
>> + For AM65X DSS, OLDI output from the SoC.
>> +
>> + endpoint@1:
>> + $ref: /schemas/graph.yaml#/properties/endpoint
>> + description:
>> + For AM625 DSS, VP Connection to OLDI1.
>> +
>> + anyOf:
>> + - required:
>> + - endpoint
>> + - required:
>> + - endpoint@0
>> + - endpoint@1
>>
>> port@1:
>> $ref: /schemas/graph.yaml#/properties/port
>> @@ -112,6 +130,22 @@ properties:
>> Input memory (from main memory to dispc) bandwidth limit in
>> bytes per second
>>
>> + oldi-txes:
>> + type: object
>> + properties:
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 0
>> +
>> + patternProperties:
>> + '^oldi_tx@[0-1]$':
>> + type: object
>> + $ref: ti,am625-oldi.yaml#
>> + unevaluatedProperties: false
>> + description: OLDI transmitters connected to the DSS VPs
>
> Connected to is not part of the DSS. I don't think these nodes belong
> here as mentioned in the other patch.
>
Replied to this in patch 2/4 to keep the discussion in one thread.
Regards
Aradhya
Powered by blists - more mailing lists