linux-kernel - Re: [PATCH] docs: gpio: prefer pread(2) for interrupt reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZkL2GkCsyKYRckj7@archie.me>
Date: Tue, 14 May 2024 12:26:50 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Huichun Feng <foxhoundsk.tw@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Jonathan Corbet <corbet@....net>,
	Kent Gibson <warthog618@...il.com>, linux-gpio@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Mao Zhu <zhumao001@...suo.com>, Ran Sun <sunran001@...suo.com>,
	Xiang wangx <wangxiang@...rlc.com>,
	Shaomin Deng <dengshaomin@...rlc.com>,
	Charles Han <hanchunchao@...pur.com>,
	Attreyee M <tintinm2017@...il.com>, LihaSika <lihasika@...il.com>
Subject: Re: [PATCH] docs: gpio: prefer pread(2) for interrupt reading

On Tue, May 14, 2024 at 12:12:23PM +0800, Huichun Feng wrote:
> In legacy sysfs GPIO, when using poll(2) on the sysfs GPIO value for
> state change awaiting, a subsequent read(2) is required for consuming
> the event, which the doc recommends the use of lseek(2) or
> close-and-reopen to reset the file offset afterwards.
> 
> The recommendations however, require at least 2 syscalls to consume
> the event. Gladly, use of pread(2) require only 1 syscall for the
> consumption. Let's advertise this usage by prioritizing its placement.
> 
> Signed-off-by: Huichun Feng <foxhoundsk.tw@...il.com>

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)