linux-kernel - Re: [PATCH] gpiolib: cdev: fix uninitialised kfifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACMJSetivWMXNu9dJyMeJTfYSsQaez_7kSHce-5NJL6=72Rd0g@mail.gmail.com>
Date: Tue, 14 May 2024 08:56:13 +0200
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Kent Gibson <warthog618@...il.com>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linus.walleij@...aro.org
Subject: Re: [PATCH] gpiolib: cdev: fix uninitialised kfifo

On Tue, 14 May 2024 at 05:37, Kent Gibson <warthog618@...il.com> wrote:
>
> On Fri, May 10, 2024 at 04:06:16PM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> >
> > On Fri, 10 May 2024 14:53:42 +0800, Kent Gibson wrote:
> > > If a line is requested with debounce, and that results in debouncing
> > > in software, and the line is subsequently reconfigured to enable edge
> > > detection then the allocation of the kfifo to contain edge events is
> > > overlooked.  This results in events being written to and read from an
> > > unitialised kfifo.  Read events are returned to userspace.
> > >
> > > Initialise the kfifo in the case where the software debounce is
> > > already active.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] gpiolib: cdev: fix uninitialised kfifo
> >       commit: 3c1625fe5a2e0d68cd7b68156f02c1b5de09a161
> >
>
> I've got a patch series to tidy this up and catch any similar errors
> earlier going forward.
> It is of course based on this patch, but that isn't in gpio/for-next yet.
> How should I proceed?
>
> Cheers,
> Kent.

Pull in current master into gpio/for-next, apply your series, make
sure it works and then wait until v6.10-rc1 is tagged because I won't
be picking up anything during merge window.

Bart